Re: Builders implement Supplier?

2024-05-15 Thread P. Ottlinger
Hi, Am 14.05.24 um 21:33 schrieb Claude Warren: My question is should we accept that Builders are Suppliers and implement them that way? This means that we would expect that a builder would have a "get()" method to retrieve the built object. If we go this route I think that we should deprecate

Re: [PR] RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected [creadur-rat]

2024-05-15 Thread via GitHub
Claudenw commented on PR #252: URL: https://github.com/apache/creadur-rat/pull/252#issuecomment-2113413503 I don't like the fix for the test errors, but there seems to be no other way. I was planning on resolving more spotbugs before merging but this at least has the tests and many of the

[jira] [Resolved] (RAT-369) Add SpotBugs and checkstyle to the pom files.

2024-05-15 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved RAT-369. --- Resolution: Fixed I think this issue is resolved.  If anyone disagrees please reopen it what a statemen