Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121854075 @ottlinger The correct version is injected by changing the POM during the build process correct? So the version would be correct during the build and the previous solution would have

[jira] [Commented] (RAT-381) Add accurate version info to the Command line parsing.

2024-05-20 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/RAT-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848054#comment-17848054 ] Philipp Ottlinger commented on RAT-381: --- I thought again and this approach should not

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121805685 @ottlinger After digging around a bit I found a solution that reads the MANIFEST if it is present by using the `Package` class. This implementation uses that to create the Ver

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121218608 Do you change the version number of the item being released after the vote? I think we are talking past eachother here. If the item is built with version number 0.16.1 then th

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121171483 @Claudenw We follow the apache way: * Generate the release candidate via maven-release-plugin (after many manual tweaks to the changelog/dokcumentation/webpage) * Upload the

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121107184 Phil, Where is the release process documented? I would like to understand where th issue is. I could not find a clean way to read the manifest without knowing the version

[jira] [Assigned] (RAT-382) Extract CLI Options into static class.

2024-05-20 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren reassigned RAT-382: - Assignee: Claude Warren > Extract CLI Options into static class. >

[jira] [Updated] (RAT-382) Extract CLI Options into static class.

2024-05-20 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated RAT-382: -- Parent: RAT-323 Issue Type: Sub-task (was: Improvement) > Extract CLI Options into static class.

[jira] [Created] (RAT-382) Extract CLI Options into static class.

2024-05-20 Thread Claude Warren (Jira)
Claude Warren created RAT-382: - Summary: Extract CLI Options into static class. Key: RAT-382 URL: https://issues.apache.org/jira/browse/RAT-382 Project: Apache Rat Issue Type: Improvement

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2121021603 @Claudenw I still have a lot of pain with the double release just to have a version string. Would it make sense to define a property or write a value inside the app's manifest we set

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on code in PR #253: URL: https://github.com/apache/creadur-rat/pull/253#discussion_r1607148308 ## apache-rat/pom.xml: ## @@ -117,6 +117,46 @@ + +org.codehaus.mojo +exec-maven-plugin + + +

[jira] [Resolved] (RAT-324) Add tests to validate that UI options update the ReportConfiguration as expected

2024-05-20 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved RAT-324. --- Resolution: Fixed resolved with pull #252 > Add tests to validate that UI options update the ReportConf

[jira] [Commented] (RAT-265) CLI: Certain wildcard file filters do not work anymore

2024-05-20 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847818#comment-17847818 ] Claude Warren commented on RAT-265: --- Fix for this issue is to change the exclude pattern b

[jira] [Resolved] (RAT-265) CLI: Certain wildcard file filters do not work anymore

2024-05-20 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/RAT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved RAT-265. --- Resolution: Fixed fixed with pull #252 > CLI: Certain wildcard file filters do not work anymore > -

Re: [PR] RAT-374: automatically update cli documentation [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw commented on PR #253: URL: https://github.com/apache/creadur-rat/pull/253#issuecomment-2120024321 @ottlinger after the merge of #252 this change becomes much smaller and clearer to read. Please review when you have a moment. I think that the Version.properties file is the correct

[jira] [Commented] (RAT-324) Add tests to validate that UI options update the ReportConfiguration as expected

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847814#comment-17847814 ] ASF subversion and git services commented on RAT-324: - Commit 995efa362c

[jira] [Commented] (RAT-265) CLI: Certain wildcard file filters do not work anymore

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847808#comment-17847808 ] ASF subversion and git services commented on RAT-265: - Commit 0188ed33d0

[jira] [Commented] (RAT-265) CLI: Certain wildcard file filters do not work anymore

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847811#comment-17847811 ] ASF subversion and git services commented on RAT-265: - Commit 4e4655dbf5

[jira] [Commented] (RAT-324) Add tests to validate that UI options update the ReportConfiguration as expected

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847812#comment-17847812 ] ASF subversion and git services commented on RAT-324: - Commit ba826a85d2

[jira] [Commented] (RAT-324) Add tests to validate that UI options update the ReportConfiguration as expected

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847809#comment-17847809 ] ASF subversion and git services commented on RAT-324: - Commit 823509bd49

[jira] [Commented] (RAT-324) Add tests to validate that UI options update the ReportConfiguration as expected

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847813#comment-17847813 ] ASF subversion and git services commented on RAT-324: - Commit 900c7d9b37

[jira] [Commented] (RAT-190) Javascript (.js) files not processed as text.

2024-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847810#comment-17847810 ] ASF subversion and git services commented on RAT-190: - Commit 474e9121df

Re: [PR] RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected [creadur-rat]

2024-05-20 Thread via GitHub
Claudenw merged PR #252: URL: https://github.com/apache/creadur-rat/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apa

Re: [PR] RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on code in PR #252: URL: https://github.com/apache/creadur-rat/pull/252#discussion_r1606438555 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -181,20 +200,21 @@ public String desc() { * The stylesheet to use to style the XML output.

Re: [PR] RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on code in PR #252: URL: https://github.com/apache/creadur-rat/pull/252#discussion_r1606413162 ## apache-rat-core/src/main/java/org/apache/rat/license/SimpleLicense.java: ## @@ -229,12 +230,16 @@ public SimpleLicense build() { if (licenseFamilies

Re: [PR] RAT-324: Add tests to validate that UI options update the ReportConfiguration as expected [creadur-rat]

2024-05-20 Thread via GitHub
ottlinger commented on code in PR #252: URL: https://github.com/apache/creadur-rat/pull/252#discussion_r1606399310 ## src/changes/changes.xml: ## @@ -72,17 +72,21 @@ https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd --> - -