Re: [PR] Tika based document analyzer - DO NOT MERGE [creadur-rat]

2024-04-25 Thread via GitHub
Claudenw commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1579860679 ## apache-rat-core/src/main/java/org/apache/rat/api/Document.java: ## @@ -33,47 +36,416 @@ public interface Document { */ enum Type { /** A

Re: [PR] Tika based document analyzer - DO NOT MERGE [creadur-rat]

2024-04-25 Thread via GitHub
Claudenw commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1578972448 ## apache-rat-core/pom.xml: ## @@ -126,5 +126,10 @@ assertj-core test + Review Comment: I missed this. I put it here for dev, yes I

Re: [PR] Tika based document analyzer - DO NOT MERGE [creadur-rat]

2024-04-25 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1578938426 ## apache-rat-core/src/main/java/org/apache/rat/api/Document.java: ## @@ -33,47 +36,416 @@ public interface Document { */ enum Type { /** A

Re: [PR] Tika based document analyzer - DO NOT MERGE [creadur-rat]

2024-04-25 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1578937305 ## apache-rat-core/pom.xml: ## @@ -126,5 +126,10 @@ assertj-core test + Review Comment: Could we add the dependency into a

Re: [PR] Tika based document analyzer - DO NOT MERGE [creadur-rat]

2024-04-23 Thread via GitHub
ottlinger commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2072736075 I'd prefer a file filter that allows ignoring no-comment plaintext files such as JSON. -- This is an automated message from the Apache Git Service. To respond to the message,