Claudenw commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1587463735
##
apache-rat-core/src/main/java/org/apache/rat/config/parameters/ComponentType.java:
##
@@ -28,6 +28,6 @@ public enum ComponentType {
MATCHER,
/** A
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579991867
##
apache-rat-core/spotbugs_ignore.xml:
##
@@ -0,0 +1,27 @@
+
+
+
+
+
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579940463
##
apache-rat-core/spotbugs_ignore.xml:
##
@@ -0,0 +1,27 @@
+
+
+
+
+
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579989686
##
apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:
##
@@ -318,7 +319,6 @@ public void log(Level level, String msg) {
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579942537
##
apache-rat-plugin/spotbugs_ignore.xml:
##
@@ -0,0 +1,27 @@
+
+
+
+
+
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579940463
##
apache-rat-core/spotbugs_ignore.xml:
##
@@ -0,0 +1,27 @@
+
+
+
+
+
Claudenw commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579490672
##
apache-rat-core/spotbugs_ignore.xml:
##
@@ -0,0 +1,27 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2068186230
Most of the errors relate to the fact that many file operations rely on the
default charset. Unfortunately newer version of the JDK provide constructors to
specify an encoding, but
ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067991533
@Claudenw the thing is that it either breaks the build or not. One can
configure exclusions in an XML file in order to tolerate certain bugs
explicitly . I'll have a look, but
Claudenw commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067961771
My thought was to turn on the spotbugs and fix any critical errors at that
time (the ones with the red circles).
We should then open fixes to remove the yellow ones and/or
ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059927715
In order to be able to bring changes intro master I'd prefer to configure
limits per module with the current threshold, thus we could make sure that no
new stuff is being added and
ottlinger commented on PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059919599
@Claudenw in case of any errors the build fails. I'm not sure if it's that
helpful or if we remove this setting on the branch .
--
This is an automated message from the Apache
ottlinger opened a new pull request, #238:
URL: https://github.com/apache/creadur-rat/pull/238
I verified locally (via ./.buildtools/generateStagingSiteInWebpageRepo) that
a report is generated, but the build is not yet configured to fail.
--
This is an automated message from the Apache
13 matches
Mail list logo
