Re: copyright-notice [WAS Re: [jira] [Commented] (WHISKER-3) The license.vm template makes too many assumptions about skipping licensing details for the primary org and license type.]
On Sat, Nov 3, 2012 at 2:49 PM, Robert Burrell Donkin robertburrelldon...@blueyonder.co.uk wrote: On 11/03/12 12:20, Robert Burrell Donkin wrote: On 11/02/12 00:44, Chip Childers wrote: On Thu, Nov 1, 2012 at 4:52 PM, Robert Burrell Donkin robertburrelldon...@blueyonder.co.uk wrote: On 10/29/12 13:46, Chip Childers wrote: snip Please do let me know if I can be of any assistance! The descriptor[1] has a lot ofcopyright-notice elements for licenses where they aren't necessary[2]. Did the documentations or the element naming (say) give the impression that this information is necessary - or were they included because that the way you want the LICENSE to be ...? snip Perhaps I hit a bug then, because I found that without a copyright tag, with-license elements were being skipped. I'll create some tests to investigate With the latest code-base, the only difference after removing copyright-notice elements from with-license elements is that the copyright claims are gone. Could you check if the problem is fixed in the current code base...? Cheers Robert I'm not able to reproduce this, so it may very well have been user error. Thanks Robert.
[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice
[ https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490903#comment-13490903 ] Robert Burrell Donkin commented on WHISKER-10: -- Added a new integration test using the full descriptor, and then removed the copyright notices without harm to the resources. Chip confirms that this potential issue doesn't seem to effect the current codebase. [1] http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3CCA%2B96GG5BtWqjkVTzCC8zGazCfvxwGZP9B7TK5-LYosVA_DBa-g%40mail.gmail.com%3E Investigate Whether with-license issues are skipped without copyright-notice Key: WHISKER-10 URL: https://issues.apache.org/jira/browse/WHISKER-10 Project: Apache Whisker Issue Type: Bug Reporter: Robert Burrell Donkin Assignee: Robert Burrell Donkin In some circumstances, it seems necessary to add copyright-notice elements before with-license elements are printed correctly. Create tests to prove whether this is still the case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: rat-jdk-1.5-maven-2 #9
See https://builds.apache.org/job/rat-jdk-1.5-maven-2/9/changes Changes: [rdonkin] RAT-123 starting to outline new documentation for core [rdonkin] Replace older-style source headers, and Eclipse tidied up some whitespace -- [...truncated 179 lines...] AU apache-rat-core/src/test/java/org/apache/rat/analysis/AnalyserFactoryTest.java A apache-rat-core/src/test/java/org/apache/rat/analysis/generation AU apache-rat-core/src/test/java/org/apache/rat/analysis/generation/GeneratedLicenseNotRequiredTest.java AU apache-rat-core/src/test/java/org/apache/rat/analysis/generation/JavaDocLicenseNotRequiredTest.java A apache-rat-core/src/test/java/org/apache/rat/analysis/util AU apache-rat-core/src/test/java/org/apache/rat/analysis/util/MatcherMultiplexerTest.java A apache-rat-core/src/test/java/org/apache/rat/walker AU apache-rat-core/src/test/java/org/apache/rat/walker/FileNameComparatorTest.java A apache-rat-core/src/test/java/org/apache/rat/header AU apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherWithBeansTest.java AU apache-rat-core/src/test/java/org/apache/rat/header/ArrayCharFilterTest.java AU apache-rat-core/src/test/java/org/apache/rat/header/FilteringSequenceFactoryTest.java AU apache-rat-core/src/test/java/org/apache/rat/header/HeaderMatcherTest.java AU apache-rat-core/src/test/java/org/apache/rat/header/SimpleCharFilter.java A apache-rat-core/src/test/java/org/apache/rat/annotation AU apache-rat-core/src/test/java/org/apache/rat/annotation/TestLicenceAppender.java AUapache-rat-core/src/test/java/org/apache/rat/ReportTest.java A apache-rat-core/src/test/java/org/apache/rat/report A apache-rat-core/src/test/java/org/apache/rat/report/xml AUapache-rat-core/src/test/java/org/apache/rat/report/xml/XmlUtils.java AU apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportFactoryTest.java AU apache-rat-core/src/test/java/org/apache/rat/report/xml/MockXmlWriter.java AU apache-rat-core/src/test/java/org/apache/rat/report/xml/XmlReportTest.java A apache-rat-core/src/test/java/org/apache/rat/report/xml/writer A apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl A apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl/base AU apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/impl/base/XmlWriterTest.java AU apache-rat-core/src/test/java/org/apache/rat/report/xml/writer/XmlWriterUtilsTest.java A apache-rat-core/src/test/java/org/apache/rat/report/claim A apache-rat-core/src/test/java/org/apache/rat/report/claim/impl A apache-rat-core/src/test/java/org/apache/rat/report/claim/impl/xml AU apache-rat-core/src/test/java/org/apache/rat/report/claim/impl/xml/MockClaimReporter.java A apache-rat-core/src/test/java/org/apache/rat/report/claim/util A apache-rat-core/src/test/java/org/apache/rat/report/analyser AU apache-rat-core/src/test/java/org/apache/rat/ReportTransformerTest.java A apache-rat-core/src/test/java/org/apache/rat/document A apache-rat-core/src/test/java/org/apache/rat/document/impl AU apache-rat-core/src/test/java/org/apache/rat/document/impl/SingularFileDocumentTest.java A apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser AU apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/ArchiveGuesserTest.java AU apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/BinaryGuesserTest.java AU apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/NoteGuesserTest.java AU apache-rat-core/src/test/java/org/apache/rat/document/impl/guesser/GuessUtilsTest.java A apache-rat-core/src/test/java/org/apache/rat/document/impl/util AU apache-rat-core/src/test/java/org/apache/rat/document/impl/util/DocumentAnalyserMultiplexerTest.java AU apache-rat-core/src/test/java/org/apache/rat/document/MockLocation.java AU apache-rat-core/src/test/java/org/apache/rat/document/ToNameTransformerTest.java AU apache-rat-core/src/test/java/org/apache/rat/document/MockDocumentAnalyser.java AU apache-rat-core/src/test/java/org/apache/rat/document/MockDocument.java A apache-rat-core/src/test/java/elements A apache-rat-core/src/test/resources A apache-rat-core/src/test/resources/artifacts AUapache-rat-core/src/test/resources/artifacts/dummy.tar.gz A apache-rat-core/src/test/resources/violations AUapache-rat-core/src/test/resources/violations/bad.txt A apache-rat-core/src/test/resources/violations/FilterTest.cs A apache-rat-core/src/test/resources/javadocs AUapache-rat-core/src/test/resources/javadocs/index.html AU
