[jira] [Created] (CURATOR-143) Introduce a max depth setting for TreeCache

2014-08-20 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-143: - Summary: Introduce a max depth setting for TreeCache Key: CURATOR-143 URL: https://issues.apache.org/jira/browse/CURATOR-143 Project: Apache Curator Issue Type: Im

[jira] [Commented] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104682#comment-14104682 ] Scott Blum commented on CURATOR-138: I don't believe there's a ticket filed yet. Fee

[jira] [Commented] (CURATOR-84) More flexibility for InterProcessMutex extensions

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104658#comment-14104658 ] ASF GitHub Bot commented on CURATOR-84: --- Github user cammckenzie commented on the pu

[GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...

2014-08-20 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/38#issuecomment-52849555 Thanks, looks good to me. I've fixed up the formatting of the unit test to match the Curator standards. Other than that, it's good to merge from my point of view. @Ra

[jira] [Commented] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104651#comment-14104651 ] Mike Drob commented on CURATOR-138: --- Do we have an existing JIRA for implementing max d

[GitHub] curator pull request: CURATOR-142 Make forkCount configurable

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104646#comment-14104646 ] ASF GitHub Bot commented on CURATOR-142: Github user asfgit closed the pull reque

[jira] [Resolved] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-142. -- Resolution: Fixed > Make surefire forkCount configurable > ---

[jira] [Commented] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104645#comment-14104645 ] ASF GitHub Bot commented on CURATOR-142: Github user asfgit closed the pull reque

[GitHub] curator pull request: CURATOR-142 Make forkCount configurable

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104640#comment-14104640 ] Mike Drob commented on CURATOR-142: --- Yes, it consistently passes with {{3}} and failed

[jira] [Updated] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-79: Fix Version/s: 2.7.0 > InterProcessMutex doesn't clean up after interrupt > ---

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104628#comment-14104628 ] ASF GitHub Bot commented on CURATOR-79: --- Github user asfgit closed the pull request

[jira] [Resolved] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-79. - Resolution: Fixed > InterProcessMutex doesn't clean up after interrupt >

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104626#comment-14104626 ] ASF GitHub Bot commented on CURATOR-132: Github user asfgit closed the pull reque

[jira] [Resolved] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-132. -- Resolution: Fixed > setACL doesn't work with namespaced curator >

[jira] [Updated] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-132: - Fix Version/s: 2.7.0 > setACL doesn't work with namespaced curator > ---

[GitHub] curator pull request: CURATOR-132 - Modified the NamespaceFacade s...

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104621#comment-14104621 ] Jordan Zimmerman commented on CURATOR-142: -- Have you tried? I tested parallel a

[jira] [Updated] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-136: - Fix Version/s: 2.7.0 > Invalid LeaderLatch path never errors > -

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104604#comment-14104604 ] ASF GitHub Bot commented on CURATOR-136: Github user asfgit closed the pull reque

[jira] [Assigned] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman reassigned CURATOR-136: Assignee: Jordan Zimmerman > Invalid LeaderLatch path never errors > -

[jira] [Resolved] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-136. -- Resolution: Fixed > Invalid LeaderLatch path never errors > --

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104594#comment-14104594 ] ASF GitHub Bot commented on CURATOR-136: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/39#issuecomment-52844699 New code pushed, incorporating feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

Jenkins build became unstable: Curator ยป Curator Recipes #894

2014-08-20 Thread Apache Jenkins Server
See

Jenkins build became unstable: Curator #894

2014-08-20 Thread Apache Jenkins Server
See

[jira] [Commented] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104530#comment-14104530 ] ASF GitHub Bot commented on CURATOR-138: Github user asfgit closed the pull reque

[GitHub] curator pull request: CURATOR-138: Rename TreeCacheEvent -> CacheE...

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman closed CURATOR-138. Resolution: Won't Fix PathChildrenCache et al will be deprecate. > Unify event listening

[jira] [Commented] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104520#comment-14104520 ] ASF GitHub Bot commented on CURATOR-138: Github user dragonsinth commented on the

[GitHub] curator pull request: CURATOR-138: Rename TreeCacheEvent -> CacheE...

2014-08-20 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/34#issuecomment-52839835 Yeah, I suppose so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104466#comment-14104466 ] ASF GitHub Bot commented on CURATOR-136: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/35#issuecomment-52836154 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104473#comment-14104473 ] ASF GitHub Bot commented on CURATOR-79: --- Github user Randgalt commented on the pull

[jira] [Commented] (CURATOR-138) Unify event listening for NodeCache, PathChildrenCache, TreeCache

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104469#comment-14104469 ] ASF GitHub Bot commented on CURATOR-138: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-138: Rename TreeCacheEvent -> CacheE...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/34#issuecomment-52836001 So, I can close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/39#issuecomment-52835862 I think each recipe should do it, yes. If possible, it could be abstracted into a single method of some kind. --- If your project is set up for it, you can reply to thi

[jira] [Commented] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104248#comment-14104248 ] ASF GitHub Bot commented on CURATOR-142: GitHub user madrob opened a pull request

[GitHub] curator pull request: CURATOR-142 Make forkCount configurable

2014-08-20 Thread madrob
GitHub user madrob opened a pull request: https://github.com/apache/curator/pull/40 CURATOR-142 Make forkCount configurable Value can be set on the command line by invocing as: mvn test -Dsurefire-forkcount=4 # Or whatever number you like This closes #40 You can merge t

[jira] [Created] (CURATOR-142) Make surefire forkCount configurable

2014-08-20 Thread Mike Drob (JIRA)
Mike Drob created CURATOR-142: - Summary: Make surefire forkCount configurable Key: CURATOR-142 URL: https://issues.apache.org/jira/browse/CURATOR-142 Project: Apache Curator Issue Type: Improveme

[jira] [Resolved] (CURATOR-120) NodeCache and PathChildrenCache should not perform writes

2014-08-20 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-120. -- Resolution: Won't Fix Given that we will deprecate these classes I don't think this is

[jira] [Commented] (CURATOR-120) NodeCache and PathChildrenCache should not perform writes

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104050#comment-14104050 ] ASF GitHub Bot commented on CURATOR-120: Github user asfgit closed the pull reque

[GitHub] curator pull request: CURATOR-120 NodeCache and PathChildrenCache ...

2014-08-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104046#comment-14104046 ] ASF GitHub Bot commented on CURATOR-136: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/39#issuecomment-52797577 I looked through them and didn't see any that wouldn't fail fast due to delegated checks in the constructors. Very possible that I missed some, though. Were you th

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104039#comment-14104039 ] ASF GitHub Bot commented on CURATOR-136: Github user Randgalt commented on the pu

[jira] [Commented] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104037#comment-14104037 ] ASF GitHub Bot commented on CURATOR-132: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/39#issuecomment-52797299 If you don't mind, this type of change should be applied to all the recipes, don't you think? --- If your project is set up for it, you can reply to this email and have

[GitHub] curator pull request: CURATOR-132 - Modified the NamespaceFacade s...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/32#issuecomment-52797168 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[jira] [Commented] (CURATOR-120) NodeCache and PathChildrenCache should not perform writes

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103962#comment-14103962 ] ASF GitHub Bot commented on CURATOR-120: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-120 NodeCache and PathChildrenCache ...

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/16#issuecomment-52789659 Given the direction that CURATOR-138 is taking, this might be a won't fix. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103945#comment-14103945 ] ASF GitHub Bot commented on CURATOR-132: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-132 - Modified the NamespaceFacade s...

2014-08-20 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/32#issuecomment-52787547 Nope - I did it by hand :P and I don't remember why I forwarded those methods. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (CURATOR-132) setACL doesn't work with namespaced curator

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103942#comment-14103942 ] ASF GitHub Bot commented on CURATOR-132: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-132 - Modified the NamespaceFacade s...

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/32#issuecomment-52786973 +1. I imagine that the delegates were auto-generated by an IDE. Ping @Randgalt just in case. --- If your project is set up for it, you can reply to this email and have yo

[jira] [Commented] (CURATOR-79) InterProcessMutex doesn't clean up after interrupt

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103931#comment-14103931 ] ASF GitHub Bot commented on CURATOR-79: --- Github user madrob commented on the pull re

[GitHub] curator pull request: CURATOR-79 - Modified the 'withProtection' h...

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/35#issuecomment-52785568 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] curator pull request: Remove services without instances

2014-08-20 Thread madrob
Github user madrob commented on the pull request: https://github.com/apache/curator/pull/5#issuecomment-52785206 Is there a JIRA issue associated with this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread John Vines (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103926#comment-14103926 ] John Vines commented on CURATOR-136: Late to the party, but I would envision the path

[jira] [Commented] (CURATOR-136) Invalid LeaderLatch path never errors

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103918#comment-14103918 ] ASF GitHub Bot commented on CURATOR-136: GitHub user madrob opened a pull request

[GitHub] curator pull request: CURATOR-136 Make LeaderLatch handling of rel...

2014-08-20 Thread madrob
GitHub user madrob opened a pull request: https://github.com/apache/curator/pull/39 CURATOR-136 Make LeaderLatch handling of relative paths consistent. LeaderLatch would previously normalize a relative path in some places but not others, causing inconsistent behavior. Make it che

[jira] [Commented] (CURATOR-84) More flexibility for InterProcessMutex extensions

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103805#comment-14103805 ] ASF GitHub Bot commented on CURATOR-84: --- Github user karkum commented on the pull re

[GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...

2014-08-20 Thread karkum
Github user karkum commented on the pull request: https://github.com/apache/curator/pull/38#issuecomment-52768395 @cammckenzie, I've added a unit test. Could you please take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] curator pull request: CURATOR-84 More flexibility for InterProcess...

2014-08-20 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/38#issuecomment-52741522 Fix looks ok to me, but I think that we need some unit tests before merging. Would be nice to have a test for the case that this ticket was raised for. i.e. Creating

[jira] [Commented] (CURATOR-84) More flexibility for InterProcessMutex extensions

2014-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103542#comment-14103542 ] ASF GitHub Bot commented on CURATOR-84: --- Github user cammckenzie commented on the pu