[GitHub] curator pull request: CURATOR-218 Reorder ConnectionState process ...

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/88#issuecomment-122622144 Agree that this is old code that should be stable. Do you have a specific scenario/test case that you think this would cause issue with, or is it "gut feeling?" --- If

[jira] [Commented] (CURATOR-218) Race condition in client.blockUntilConnected()

[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632688#comment-14632688 ] ASF GitHub Bot commented on CURATOR-218: Github user madrob commented on the pull

[jira] [Commented] (CURATOR-234) Add test logging back to modules

[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632687#comment-14632687 ] ASF GitHub Bot commented on CURATOR-234: Github user madrob commented on the pull

[GitHub] curator pull request: CURATOR-234 Add slf4j-log4j12 test dependenc...

Github user madrob commented on the pull request: https://github.com/apache/curator/pull/90#issuecomment-122620348 When you run tests, since there is currently no binding you wouldn't get any logging. ``` mdrob@mdrob-W530:~/workspace/curator$ cat curator-client/target/sur

[GitHub] curator pull request: CURATOR-218 Reorder ConnectionState process ...

Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/88#issuecomment-122571772 I'm looking at this very carefully. It makes sense but this is old old code and deep deep in the heart of things. We should proceed with caution. --- If your project i

[jira] [Commented] (CURATOR-218) Race condition in client.blockUntilConnected()

[ https://issues.apache.org/jira/browse/CURATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632544#comment-14632544 ] ASF GitHub Bot commented on CURATOR-218: Github user Randgalt commented on the pu

[jira] [Commented] (CURATOR-234) Add test logging back to modules

[ https://issues.apache.org/jira/browse/CURATOR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632538#comment-14632538 ] ASF GitHub Bot commented on CURATOR-234: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-234 Add slf4j-log4j12 test dependenc...

Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/90#issuecomment-122571331 What problem is this solving? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Assigned] (CURATOR-235) LeaderSelector.internalRequeue should be private

[ https://issues.apache.org/jira/browse/CURATOR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman reassigned CURATOR-235: Assignee: Jordan Zimmerman > LeaderSelector.internalRequeue should be private > --

[jira] [Resolved] (CURATOR-235) LeaderSelector.internalRequeue should be private

[ https://issues.apache.org/jira/browse/CURATOR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-235. -- Resolution: Fixed > LeaderSelector.internalRequeue should be private >

[jira] [Commented] (CURATOR-232) Consolidate test code

[ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632531#comment-14632531 ] ASF GitHub Bot commented on CURATOR-232: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-232 Consolidate Timing and Client

Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/89#issuecomment-122570334 I'm concerned about the number of changes in this PR. I like the idea of putting some common functionality in BaseClassForTests but I think it's too risky to touch all

[jira] [Commented] (CURATOR-232) Consolidate test code

[ https://issues.apache.org/jira/browse/CURATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632530#comment-14632530 ] ASF GitHub Bot commented on CURATOR-232: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-232 Consolidate Timing and Client

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/89#discussion_r34949657 --- Diff: curator-framework/src/test/java/org/apache/curator/framework/FrameworkTest.java --- @@ -0,0 +1,83 @@ +/* --- End diff -- I don't