[jira] [Resolved] (CURATOR-167) All registered watchers should be cleared on close

2015-08-25 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cameron McKenzie resolved CURATOR-167. -- Resolution: Fixed > All registered watchers should be cleared on close > --

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-08-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712533#comment-14712533 ] ASF GitHub Bot commented on CURATOR-167: Github user asfgit closed the pull reque

[GitHub] curator pull request: CURATOR-167 - Partial fix to clean up Curato...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Updated] (CURATOR-254) TestBoundedDistributedQueue:testMulti fails intermittently

2015-08-25 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-254: - Fix Version/s: 2.9.0 > TestBoundedDistributedQueue:testMulti fails intermittently > -

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-08-25 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712506#comment-14712506 ] Jordan Zimmerman commented on CURATOR-167: -- If the test breakage is unrelated to

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-08-25 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712503#comment-14712503 ] Cameron McKenzie commented on CURATOR-167: -- I still need to merge it into master

[jira] [Commented] (CURATOR-233) Bug in double barrier

2015-08-25 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712498#comment-14712498 ] Jordan Zimmerman commented on CURATOR-233: -- Can this be pushed out to 2.9.1 (or

[jira] [Commented] (CURATOR-167) All registered watchers should be cleared on close

2015-08-25 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712497#comment-14712497 ] Jordan Zimmerman commented on CURATOR-167: -- So, can this be closed now? > All r

Re: CURATOR-217?

2015-08-25 Thread Cameron McKenzie
I have raised CURATOR-254 for this. On Wed, Aug 26, 2015 at 10:41 AM, Cameron McKenzie wrote: > I've had a bit of a look at it and the test seems very fragile. It already > has a bit of built in margin for error, but it relies on the consumers > being able to consume messages off the queue faste

[jira] [Commented] (CURATOR-254) TestBoundedDistributedQueue:testMulti fails intermittently

2015-08-25 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712280#comment-14712280 ] Cameron McKenzie commented on CURATOR-254: -- Perhaps this is an actual issue. The

[jira] [Updated] (CURATOR-254) TestBoundedDistributedQueue:testMulti fails intermittently

2015-08-25 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cameron McKenzie updated CURATOR-254: - Description: The TestBoundedDistributedQueue:testMulti fails intermittently. See attached

[jira] [Updated] (CURATOR-254) TestBoundedDistributedQueue:testMulti fails intermittently

2015-08-25 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cameron McKenzie updated CURATOR-254: - Attachment: TEST-org.apache.curator.framework.recipes.queue.TestBoundedDistributedQueue.x

[jira] [Created] (CURATOR-254) TestBoundedDistributedQueue:testMulti fails intermittently

2015-08-25 Thread Cameron McKenzie (JIRA)
Cameron McKenzie created CURATOR-254: Summary: TestBoundedDistributedQueue:testMulti fails intermittently Key: CURATOR-254 URL: https://issues.apache.org/jira/browse/CURATOR-254 Project: Apache Cur

Re: CURATOR-217?

2015-08-25 Thread Cameron McKenzie
I've had a bit of a look at it and the test seems very fragile. It already has a bit of built in margin for error, but it relies on the consumers being able to consume messages off the queue faster than they are produced. If more than 20 messages end up on the queue at any time then test test fails

Re: CURATOR-217?

2015-08-25 Thread Cameron McKenzie
Thanks Mike, On master. I'll have a bit of a look into it and let you know. I think that it's a race condition based on how the test is structured. cheers On Wed, Aug 26, 2015 at 9:18 AM, Mike Drob wrote: > Is this on 3.0 or master? Can you create a JIRA with some log output? > > On Tue, Aug 25,

Re: CURATOR-217?

2015-08-25 Thread Mike Drob
Is this on 3.0 or master? Can you create a JIRA with some log output? On Tue, Aug 25, 2015 at 6:15 PM, Cameron McKenzie wrote: > Is anyone seeing fairly consistent failure of the > > TestBoundedDistributedQueue.testMulti:184 > > test? When I run from inside eclipse in isolation it seems ok, but

Re: CURATOR-217?

2015-08-25 Thread Cameron McKenzie
Is anyone seeing fairly consistent failure of the TestBoundedDistributedQueue.testMulti:184 test? When I run from inside eclipse in isolation it seems ok, but running a 'mvn test' seems to fail on this test with some consistency. The changes for CURATOR-167 certainly haven't caused this to happen

Jenkins build is back to normal : Curator-3.0 » Curator Framework #6

2015-08-25 Thread Apache Jenkins Server
See

Jenkins build is back to stable : Curator-3.0 » Curator Recipes #6

2015-08-25 Thread Apache Jenkins Server
See

Jenkins build is back to normal : Curator-3.0 #6

2015-08-25 Thread Apache Jenkins Server
See

Re: CURATOR-217?

2015-08-25 Thread Cameron McKenzie
Thanks Scott, I will merge into master. cheers On Wed, Aug 26, 2015 at 1:00 AM, Scott Blum wrote: > Yep, that looks perfect. Is CURATOR-167 done? If so, we can just > fast-foward merge it into master now. > > On Tue, Aug 25, 2015 at 12:11 AM, Cameron McKenzie > > wrote: > > > Thanks Scott, >

[jira] [Commented] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711894#comment-14711894 ] Mike Drob commented on CURATOR-161: --- Oh, I didn't know we had that. Ran it and pushed t

[jira] [Commented] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711884#comment-14711884 ] Jordan Zimmerman commented on CURATOR-161: -- You can run: mvn license:format

[jira] [Comment Edited] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711780#comment-14711780 ] Mike Drob edited comment on CURATOR-161 at 8/25/15 6:54 PM: B

[jira] [Commented] (CURATOR-161) Support Watcher Removal

2015-08-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711780#comment-14711780 ] Mike Drob commented on CURATOR-161: --- {noformat} [INFO] Missing header in: curator-fram

Jenkins build is back to normal : Curator-3.0 » Curator Testing #5

2015-08-25 Thread Apache Jenkins Server
See

Build failed in Jenkins: Curator-3.0 #5

2015-08-25 Thread Apache Jenkins Server
See -- [...truncated 1667 lines...] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.146 sec - in org.apache.curator.ensemble.exhibitor.TestExhibitorEnsembleProvider Running org.apache.curator.

Build failed in Jenkins: Curator-3.0 » Curator Framework #5

2015-08-25 Thread Apache Jenkins Server
See -- [INFO] [INFO] [INFO]

Re: Build failed in Jenkins: Curator-3.0 #4

2015-08-25 Thread Mike Drob
Apologies for the noise here. When I initially configured the Curator-3.0 job, I missed that it needed to be Java 7, so we're ending up with a few failed builds because of that. On Tue, Aug 25, 2015 at 1:19 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

Build failed in Jenkins: Curator-3.0 #4

2015-08-25 Thread Apache Jenkins Server
See -- [...truncated 1113 lines...] [INFO] Downloaded: https://repo.maven.apache.org/maven2/org/codehaus/woodstox/wstx-asl/3.2.6/wstx-asl-3.2.6.jar (509 KB at 7585.0 KB/sec) [INFO] Downloaded: https://repo.ma

Build failed in Jenkins: Curator-3.0 » Curator Testing #4

2015-08-25 Thread Apache Jenkins Server
See -- [INFO] [INFO] [INFO] Buil

Build failed in Jenkins: Curator-3.0 #3

2015-08-25 Thread Apache Jenkins Server
See -- Started by user mdrob [EnvInject] - Loading node environment variables. Building remotely on ubuntu-1 (docker Ubuntu ubuntu ubuntu1) in workspace Wiping ou

Re: DistributedDoubleBarrier semantics

2015-08-25 Thread Jordan Zimmerman
Unfortunately, the recipes don’t list edge cases. The algorithm is described here: http://zookeeper.apache.org/doc/trunk/recipes.html#sc_doubleBarriers As I recall, when I wrote it I just followed the recipe as listed. I think some others have contributed to the code as well. I never really und

DistributedDoubleBarrier semantics

2015-08-25 Thread Mike Drob
Devs, I was working on CURATOR-233 and I realized that I don't really understand the semantics of the DistributedDoubleBarrier when there are more clients than the given member quantity. Note that I'm not asking about what the code currently does (because I suspect it has a few inconsistencies) bu

Re: CURATOR-217?

2015-08-25 Thread Scott Blum
Yep, that looks perfect. Is CURATOR-167 done? If so, we can just fast-foward merge it into master now. On Tue, Aug 25, 2015 at 12:11 AM, Cameron McKenzie wrote: > Thanks Scott, > Done, would you mind checking the origin/CURATOR-167 to make sure that I > haven't done anything wrong! I have done

[jira] [Commented] (CURATOR-233) Bug in double barrier

2015-08-25 Thread J D (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711403#comment-14711403 ] J D commented on CURATOR-233: - Hi Mike, Thanks for the fix. I will test/have a look at it o

[jira] [Commented] (CURATOR-94) PERMANENT registration should not be added to the services map.

2015-08-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710851#comment-14710851 ] ASF GitHub Bot commented on CURATOR-94: --- Github user dtrott commented on the pull re

[GitHub] curator pull request: Curator 94

2015-08-25 Thread dtrott
Github user dtrott commented on the pull request: https://github.com/apache/curator/pull/2#issuecomment-134519167 I am afraid that this patch is more than a year old and the underlying code has changed. I believe the original code with the patch applied looked like this:

[GitHub] curator pull request: Curator 94

2015-08-25 Thread Lunanne
Github user Lunanne commented on the pull request: https://github.com/apache/curator/pull/2#issuecomment-134506044 First of all thank you for this PR, I was looking into some other issues with permanent service types and this would certainly have been a big problem as I did expect per