[jira] [Commented] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122251#comment-15122251 ] ASF GitHub Bot commented on CURATOR-294: GitHub user dragonsinth opened a pull re

[GitHub] curator pull request: CURATOR-294

2016-01-28 Thread dragonsinth
GitHub user dragonsinth opened a pull request: https://github.com/apache/curator/pull/127 CURATOR-294 @Randgalt You can merge this pull request into a Git repository by running: $ git pull https://github.com/dragonsinth/curator CURATOR-294 Alternatively you can review and app

[jira] [Commented] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122162#comment-15122162 ] Jordan Zimmerman commented on CURATOR-294: -- Create a PR on Github. > Optimize T

[jira] [Commented] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122155#comment-15122155 ] Scott Blum commented on CURATOR-294: [~randgalt] I pushed a branch, would you mind re

[jira] [Comment Edited] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122155#comment-15122155 ] Scott Blum edited comment on CURATOR-294 at 1/28/16 7:28 PM: -

Re: TreeCache question

2016-01-28 Thread Nick Hill
Sounds great to me! Thanks!! Quoting Scott Blum : https://issues.apache.org/jira/browse/CURATOR-294 On Thu, Jan 28, 2016 at 11:38 AM, Scott Blum wrote: Nick, Looking at this closer, I see your point! There is a potential race between an update thread updating stat+data, and a reader thre

[jira] [Updated] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-294: - Fix Version/s: 2.9.2 3.0.1 > Optimize TreeCache, fix possible concurre

[jira] [Commented] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121851#comment-15121851 ] Scott Blum commented on CURATOR-294: Nick, Looking at this closer, I see your point!

[jira] [Commented] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121849#comment-15121849 ] Scott Blum commented on CURATOR-294: It just seems that not guaranteeing consistency

Re: TreeCache question

2016-01-28 Thread Scott Blum
https://issues.apache.org/jira/browse/CURATOR-294 On Thu, Jan 28, 2016 at 11:38 AM, Scott Blum wrote: > Nick, > > Looking at this closer, I see your point! There is a potential race > between an update thread updating stat+data, and a reader thread accessing > it, and it looks like we could mak

[jira] [Created] (CURATOR-294) Optimize TreeCache, fix possible concurrency issue

2016-01-28 Thread Scott Blum (JIRA)
Scott Blum created CURATOR-294: -- Summary: Optimize TreeCache, fix possible concurrency issue Key: CURATOR-294 URL: https://issues.apache.org/jira/browse/CURATOR-294 Project: Apache Curator Issue

Re: TreeCache question

2016-01-28 Thread Scott Blum
Nick, Looking at this closer, I see your point! There is a potential race between an update thread updating stat+data, and a reader thread accessing it, and it looks like we could make some changes to the implementation to simplify and fix this without affecting the public API. Here's a tentativ

Re: TreeCache question

2016-01-28 Thread Nick Hill
Thanks Cameron, Scott, I'm not aware of any concurrency bugs in TreeCache right now, I don't think I relied on the atomic refs for safety. I guess I wasn't aware in general that atomic refs had a purpose other than this. It just seems that not guaranteeing consistency of the stat and data