[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread cammckenzie
GitHub user cammckenzie opened a pull request: https://github.com/apache/curator/pull/157 Long session timeout issue Fix for issue where LOST events were created at 4/3 of the session timeout rather than at the end of session timeout. You can merge this pull request into a Git repo

Re: CURATOR-3.0 tests

2016-06-13 Thread Cameron McKenzie
Done, have created a PR. On Mon, Jun 13, 2016 at 1:22 PM, Cameron McKenzie wrote: > Yep, I will try and do it tomorrow > On 13 Jun 2016 1:19 PM, "Jordan Zimmerman" > wrote: > >> Sure - you OK doing it? >> >> > On Jun 12, 2016, at 10:09 PM, Cameron McKenzie >> wrote: >> > >> > It could probably

[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/157#discussion_r66905732 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -252,7 +252,9 @@ private void processEvents

[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/157#discussion_r66905783 --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestInterProcessSemaphore.java --- @@ -148,10 +148,9 @@ else if ( newSta

[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/157#discussion_r66905910 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -252,7 +252,9 @@ private void processEve

[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/157#discussion_r66905969 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -252,7 +252,9 @@ private void processEvents

[GitHub] curator pull request #157: Long session timeout issue

2016-06-13 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/157#discussion_r66906186 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -252,7 +252,9 @@ private void processEve

[GitHub] curator issue #157: Long session timeout issue

2016-06-13 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/157 Ok, I've pushed some additional changes to fix your comments. Are you happy for me to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on Git