[jira] [Commented] (CURATOR-390) Create better summary of what Apache Curator is/does

2017-03-13 Thread Tsuyoshi Ozawa (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923490#comment-15923490 ] Tsuyoshi Ozawa commented on CURATOR-390: I wrote a plain draft, so sharing it her

Re: Determining ZNode change for the cache recipes

2017-03-13 Thread Tsuyoshi OZAWA
I also agree that it's enough to use mzxid in the case. As you know, zxid is global value which is used to be stamped in znode as czxid, mzxid, and pzxid. It's monotonically increased even when a znode is deleted. On the other hand, the version in znode can be reset once the znode is deleted. It's

[jira] [Commented] (CURATOR-391) PathChildrenCache missing events upon reconnection

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923463#comment-15923463 ] ASF GitHub Bot commented on CURATOR-391: Github user oza commented on the issue:

[GitHub] curator issue #202: [CURATOR-391] Cannot use only Stat version to determine ...

2017-03-13 Thread oza
Github user oza commented on the issue: https://github.com/apache/curator/pull/202 Please ignore my previous comment. Rethinking of the point, because I confirmed that clearDataBytes is for clearing data with a specified version for suppressing memory consumption(not for data manageme

[jira] [Commented] (CURATOR-391) PathChildrenCache missing events upon reconnection

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923422#comment-15923422 ] ASF GitHub Bot commented on CURATOR-391: Github user oza commented on the issue:

[GitHub] curator issue #202: [CURATOR-391] Cannot use only Stat version to determine ...

2017-03-13 Thread oza
Github user oza commented on the issue: https://github.com/apache/curator/pull/202 Should we also fix in the checking of version in ```clearDataBytes```? ``` public boolean clearDataBytes(String fullPath, int ifVersion) { ChildData data = currentData

[jira] [Commented] (CURATOR-311) SharedValue could hold stall data when quourm membership changes

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923371#comment-15923371 ] ASF GitHub Bot commented on CURATOR-311: Github user oza commented on the issue:

[GitHub] curator issue #200: [CURATOR-311] SharedValue could hold stall data after re...

2017-03-13 Thread oza
Github user oza commented on the issue: https://github.com/apache/curator/pull/200 @Randgalt could you take a look when you have a time? I'm sorry if I'm missing something in previous PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (CURATOR-378) Dependency Refresh

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923306#comment-15923306 ] ASF GitHub Bot commented on CURATOR-378: Github user cammckenzie commented on a d

[GitHub] curator pull request #204: [CURATOR-378] Update mvn parent pom, plugin and o...

2017-03-13 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/204#discussion_r105804310 --- Diff: pom.xml --- @@ -62,22 +62,22 @@ 3.4.8 - 2.7 -2.3.7 -2.10.3 - 1

[jira] [Commented] (CURATOR-378) Dependency Refresh

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923304#comment-15923304 ] ASF GitHub Bot commented on CURATOR-378: Github user lvfangmin commented on a dif

[GitHub] curator pull request #204: [CURATOR-378] Update mvn parent pom, plugin and o...

2017-03-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/curator/pull/204#discussion_r105804055 --- Diff: pom.xml --- @@ -62,22 +62,22 @@ 3.4.8 - 2.7 -2.3.7 -2.10.3 - 1.6

[jira] [Commented] (CURATOR-378) Dependency Refresh

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923237#comment-15923237 ] ASF GitHub Bot commented on CURATOR-378: Github user cammckenzie commented on a d

[GitHub] curator pull request #204: [CURATOR-378] Update mvn parent pom, plugin and o...

2017-03-13 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/204#discussion_r105800775 --- Diff: pom.xml --- @@ -62,22 +62,22 @@ 3.4.8 - 2.7 -2.3.7 -2.10.3 - 1

[jira] [Commented] (CURATOR-392) Zookeeper Ensemble Get Incorrect Address

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922928#comment-15922928 ] ASF GitHub Bot commented on CURATOR-392: GitHub user Vile2539 opened a pull reque

[GitHub] curator pull request #205: [CURATOR-392] Fixing connection string constructi...

2017-03-13 Thread Vile2539
GitHub user Vile2539 opened a pull request: https://github.com/apache/curator/pull/205 [CURATOR-392] Fixing connection string construction for wildcard client addresses The client address in Zookeeper can be a wildcard (0.0.0.0), and if this is used by Curator, it will attempt to c

[jira] [Commented] (CURATOR-386) Allow listener to be passed in to PersistentNode to notify for node creation events

2017-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15914055#comment-15914055 ] ASF GitHub Bot commented on CURATOR-386: Github user lvfangmin commented on a dif

[GitHub] curator pull request #198: [CURATOR-386] Allow listener to be passed in to P...

2017-03-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/curator/pull/198#discussion_r105545812 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -117,6 +120,7 @@ public void processResult(