[GitHub] curator issue #225: CURATOR-295, removed cache close, catch provider close e...

2017-06-25 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/225 Thanks for this. This will take me a bit of time to look over. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (CURATOR-295) Service discovery close attempts to double-close caches

2017-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062352#comment-16062352 ] ASF GitHub Bot commented on CURATOR-295: Github user Randgalt commented on the is

PRs that could use review

2017-06-25 Thread Jordan Zimmerman
Hi Folks, If anyone has time, these PRs need more review: https://github.com/apache/curator/pull/225 https://github.com/apache/curator/pull/223 https://github.com/apache/curator/pull/216

[jira] [Commented] (CURATOR-362) Curator framework create API with ACL Mode is not adding the ACL to the parent nodes if select creatingParentsIfNeeded

2017-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062457#comment-16062457 ] ASF GitHub Bot commented on CURATOR-362: Github user cammckenzie commented on a d

[GitHub] curator pull request #223: [CURATOR-362] Use provided ACL when creating pare...

2017-06-25 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/223#discussion_r123912201 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/ExistsBuilderImpl.java --- @@ -185,7 +185,7 @@ public Stat forPath(String p