[jira] [Updated] (CURATOR-486) InterProcessMutex.release fails to remove a lock on retries.

2018-11-27 Thread Purshotam Shah (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Purshotam Shah updated CURATOR-486: --- Description: We were planning to build a release lock retry, looks like InterProcessMutex.r

[jira] [Created] (CURATOR-486) InterProcessMutex.release fails to remove a lock on retries.

2018-11-27 Thread Purshotam Shah (JIRA)
Purshotam Shah created CURATOR-486: -- Summary: InterProcessMutex.release fails to remove a lock on retries. Key: CURATOR-486 URL: https://issues.apache.org/jira/browse/CURATOR-486 Project: Apache Cura

[GitHub] curator issue #261: [CURATOR-452] Fix race condition on cache in ServiceCach...

2018-11-27 Thread cmckn
Github user cmckn commented on the issue: https://github.com/apache/curator/pull/261 I realize this issue has been closed, but I'm still seeing unexpected exceptions in some of my applications during `ServiceCacheImpl#start`. The merged changes to address this added a null-check ar

[jira] [Commented] (CURATOR-452) ChildData.getData() can be null

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700922#comment-16700922 ] ASF GitHub Bot commented on CURATOR-452: Github user cmckn commented on the issu

[GitHub] curator issue #281: [CURATOR-483] Fix path used when re-creating sequential ...

2018-11-27 Thread njhill
Github user njhill commented on the issue: https://github.com/apache/curator/pull/281 @cammckenzie @Randgalt still interested in this fix? :) ---

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700941#comment-16700941 ] ASF GitHub Bot commented on CURATOR-483: Github user njhill commented on the iss

[GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...

2018-11-27 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/281#discussion_r236829857 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -422,6 +422,9 @@ protected void deleteNode()

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700954#comment-16700954 ] ASF GitHub Bot commented on CURATOR-483: Github user Randgalt commented on a dif

[GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...

2018-11-27 Thread njhill
Github user njhill commented on a diff in the pull request: https://github.com/apache/curator/pull/281#discussion_r236832802 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -422,6 +422,9 @@ protected void deleteNode() t

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700970#comment-16700970 ] ASF GitHub Bot commented on CURATOR-483: Github user njhill commented on a diff

[GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...

2018-11-27 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/281#discussion_r236835804 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -422,6 +422,9 @@ protected void deleteNode()

[GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...

2018-11-27 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/281#discussion_r236835917 --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java --- @@ -422,6 +422,9 @@ protected void deleteNode()

[GitHub] curator issue #281: [CURATOR-483] Fix path used when re-creating sequential ...

2018-11-27 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/281 I'm OK with this now. ---

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700981#comment-16700981 ] ASF GitHub Bot commented on CURATOR-483: Github user Randgalt commented on a dif

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700982#comment-16700982 ] ASF GitHub Bot commented on CURATOR-483: Github user Randgalt commented on the i

[GitHub] curator issue #281: [CURATOR-483] Fix path used when re-creating sequential ...

2018-11-27 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/281 Yep, I've been meaning to merge, just having issues running some unit tests (which are unrelated to this PR). I will try and merge it today. ---

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700984#comment-16700984 ] ASF GitHub Bot commented on CURATOR-483: Github user cammckenzie commented on th

[GitHub] curator issue #281: [CURATOR-483] Fix path used when re-creating sequential ...

2018-11-27 Thread njhill
Github user njhill commented on the issue: https://github.com/apache/curator/pull/281 Great, thanks @cammckenzie @Randgalt. And I just noticed something odd which may be contributing to the confusion ... at least for me right now the commits on the Commits tab are showing in the oppos

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700991#comment-16700991 ] ASF GitHub Bot commented on CURATOR-483: Github user njhill commented on the iss

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700979#comment-16700979 ] ASF GitHub Bot commented on CURATOR-483: Github user Randgalt commented on a dif

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701061#comment-16701061 ] ASF GitHub Bot commented on CURATOR-483: Github user asfgit closed the pull requ

[GitHub] curator pull request #281: [CURATOR-483] Fix path used when re-creating sequ...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/281 ---

[GitHub] curator issue #281: [CURATOR-483] Fix path used when re-creating sequential ...

2018-11-27 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/281 Thanks for the fix @njhill ---

[jira] [Commented] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701065#comment-16701065 ] ASF GitHub Bot commented on CURATOR-483: Github user cammckenzie commented on th

[jira] [Closed] (CURATOR-483) Sequential PersistentNodes with protection don't resync after reconnection

2018-11-27 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cameron McKenzie closed CURATOR-483. Resolution: Fixed Fix Version/s: 4.1.0 > Sequential PersistentNodes with protection

Build failed in Jenkins: Curator #53

2018-11-27 Thread Apache Jenkins Server
See Changes: [nickhill] fix path used when re-creating sequential PersistentNode with protection [nickhill] add targeted unit test for bug/fix [nickhill] change to use if statements; remove redundant isSequential method

Re: Unit tests

2018-11-27 Thread Cameron McKenzie
Did you get anywhere with this Jordan? I've just done a bit of debugging on it, and it seems that when the teardown() method in the BaseClassForTests method gets called, the close() method on the server instance does not kill one of the threads. There is a ReaderThread that seems to run indefinite

[jira] [Commented] (CURATOR-409) TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta

2018-11-27 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701238#comment-16701238 ] Cameron McKenzie commented on CURATOR-409: -- [~risdenk], actually there is somet

[jira] [Commented] (CURATOR-409) TestingQuorumPeerMain does not work with Zookeeper 3.5.3-beta

2018-11-27 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701350#comment-16701350 ] Kevin Risden commented on CURATOR-409: -- I just setup my local Jenkins server to run