[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754581#comment-16754581 ] ASF GitHub Bot commented on CURATOR-498: Github user cammckenzie commented on a diff in the pull

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251685066 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754580#comment-16754580 ] ASF GitHub Bot commented on CURATOR-498: Github user Randgalt commented on the issue:

[GitHub] curator issue #303: [CURATOR-498] Protected Mode creation can mistake closin...

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/303 It's odd - only 1 test is failing: TestTreeCache.testKilledSession(). I can make it work by special casing via `if ( client.isZk34CompatibilityMode() )` but I wonder why? ZK is sending a node

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754579#comment-16754579 ] ASF GitHub Bot commented on CURATOR-498: Github user Randgalt commented on a diff in the pull

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251684425 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[jira] [Commented] (CURATOR-458) Fix a bug spotted by error-prone compiler

[ https://issues.apache.org/jira/browse/CURATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754530#comment-16754530 ] ASF GitHub Bot commented on CURATOR-458: Github user Randgalt commented on the issue:

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754529#comment-16754529 ] ASF GitHub Bot commented on CURATOR-498: Github user cammckenzie commented on a diff in the pull

[GitHub] curator issue #257: CURATOR-458: Fix a bug spotted by error-prone compiler

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/257 Yeah - I don't really see the need for this. ---

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251672915 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[jira] [Commented] (CURATOR-458) Fix a bug spotted by error-prone compiler

[ https://issues.apache.org/jira/browse/CURATOR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754515#comment-16754515 ] ASF GitHub Bot commented on CURATOR-458: Github user cammckenzie commented on the issue:

[GitHub] curator issue #257: CURATOR-458: Fix a bug spotted by error-prone compiler

Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/257 Any thoughts on this @Randgalt . I've had a look at it, and the changes seem fine, but equally, they're not adding a great deal (other than stopping some error prone complaints). ---

Jenkins build became unstable: Curator » Curator ZooKeeper 3.4 Testing #94

See

Jenkins build became unstable: Curator #94

See

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/302 Not at this time. It would be pretty disruptive and there hasn't been a call for it. But, if someone proposes something it will definitely be considered. ---

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user eolivelli commented on the issue: https://github.com/apache/curator/pull/302 @Randgalt thanks for the pointer. Is there any roadmap towards breaking the API and drop Guava classes at least from the public surface of the project? ---

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754372#comment-16754372 ] ASF GitHub Bot commented on CURATOR-498: Github user Randgalt commented on a diff in the pull

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251599266 --- Diff: curator-client/src/main/java/org/apache/curator/utils/InjectSessionExpiration.java --- @@ -94,7 +89,7 @@ public static void

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754357#comment-16754357 ] ASF GitHub Bot commented on CURATOR-498: Github user shayshim commented on a diff in the pull

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/302 Also see here: https://cwiki.apache.org/confluence/display/CURATOR/TN13 ---

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

Github user shayshim commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251593572 --- Diff: curator-client/src/main/java/org/apache/curator/utils/InjectSessionExpiration.java --- @@ -94,7 +89,7 @@ public static void

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/302 TBH - this PR is not needed. But, we keep getting requests for it so I'm OK with making the change. But, it's not trivial. Several parts of the codebase need to be updated. ---

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user eolivelli commented on the issue: https://github.com/apache/curator/pull/302 Ops. Sorry. I didn't notice. ---

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/302 It already is shaded. see here: https://github.com/apache/curator/blob/master/curator-client/pom.xml#L90 ---

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user eolivelli commented on the issue: https://github.com/apache/curator/pull/302 @Randgalt as guava has a lot of issues about forward/backward compatibility, did you ever consider to shade it and relocate packages? ---

[jira] [Commented] (CURATOR-502) Update dependency com.google.guava:guava of org.apache.curator:curator-client

[ https://issues.apache.org/jira/browse/CURATOR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754332#comment-16754332 ] ASF GitHub Bot commented on CURATOR-502: Github user Randgalt commented on the issue:

[GitHub] curator issue #302: Update guava-version to 27.0.1

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/302 This doesn't compile for me - I get a ton of errors. Also, please rename the PR so that to something like: `[CURATOR-502] Update guava-version to 27.0.1` ---

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754289#comment-16754289 ] ASF GitHub Bot commented on CURATOR-498: GitHub user Randgalt opened a pull request:

[jira] [Updated] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-498: - Fix Version/s: 4.1.1 > Protected Mode creation can mistake closing session's node

[jira] [Commented] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754291#comment-16754291 ] ASF GitHub Bot commented on CURATOR-498: Github user Randgalt commented on the issue:

[jira] [Updated] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-498: - Component/s: Framework > Protected Mode creation can mistake closing session's node

[jira] [Updated] (CURATOR-498) Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch

[ https://issues.apache.org/jira/browse/CURATOR-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-498: - Summary: Protected Mode creation can mistake closing session's node causing problems

[GitHub] curator issue #303: [CURATOR-498] Protected Mode creation can mistake closin...

Github user Randgalt commented on the issue: https://github.com/apache/curator/pull/303 attn: @shayshim ---

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

GitHub user Randgalt opened a pull request: https://github.com/apache/curator/pull/303 [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch Kudos to user Shay Shimony for his tireless and excellent work

[jira] [Commented] (CURATOR-502) Update dependency com.google.guava:guava of org.apache.curator:curator-client

[ https://issues.apache.org/jira/browse/CURATOR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754181#comment-16754181 ] DW commented on CURATOR-502: PR [https://github.com/apache/curator/pull/302..] Let me know if you need

[GitHub] curator pull request #302: Update guava-version to 27.0.1

GitHub user dawinter opened a pull request: https://github.com/apache/curator/pull/302 Update guava-version to 27.0.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawinter/curator master Alternatively you can review and

[jira] [Commented] (CURATOR-502) Update dependency com.google.guava:guava of org.apache.curator:curator-client

[ https://issues.apache.org/jira/browse/CURATOR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754111#comment-16754111 ] Jordan Zimmerman commented on CURATOR-502: -- The CVE would be nice. Is this really urgent? I

[jira] [Commented] (CURATOR-502) Update dependency com.google.guava:guava of org.apache.curator:curator-client

[ https://issues.apache.org/jira/browse/CURATOR-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753840#comment-16753840 ] DW commented on CURATOR-502: [~randgalt] Do you have any outlook for the update? > Update dependency