Re: [DISCUSS] CURATOR-533

Thanks for the updated explanation, that certainly makes sense. On Mon, Jul 29, 2019 at 10:47 AM Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > Sure - makes sense Cameron.. > > When CURATOR-533 was written, each ConnectionStateListener created was > mapped a new CircuitBreaker instance.

Re: [DISCUSS] CURATOR-533

Sure - makes sense Cameron.. When CURATOR-533 was written, each ConnectionStateListener created was mapped a new CircuitBreaker instance. In hindsight, this doesn't make sense. Only a single, shared CircuitBreaker is needed. Here's the email that the Elastic engineer sent to me originally that

Re: [DISCUSS] CURATOR-533

hey Jordan, Can you expand on why the previous implementation was not ideal? Given that the decorator approach was only introduced recently, I don't imagine it has had a lot of uptake, but it may be worth asking the question on the curator-user list to work out if there's going to be any impact in

Build failed in Jenkins: Curator #130

See Changes: [eolivelli] Switch to OpenJDK 8 and 11 [eolivelli] Turn off spammy logs -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely

[jira] [Work logged] (CURATOR-534) Fix Travis-CI config

[ https://issues.apache.org/jira/browse/CURATOR-534?focusedWorklogId=283904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283904 ] ASF GitHub Bot logged work on CURATOR-534: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on issue #319: [CURATOR-534] Switch to OpenJDK 8 and 11

Randgalt commented on issue #319: [CURATOR-534] Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515779812 Thank you! This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (CURATOR-534) Fix Travis-CI config

[ https://issues.apache.org/jira/browse/CURATOR-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-534. -- Resolution: Fixed > Fix Travis-CI config > > > Ke

[GitHub] [curator] asfgit merged pull request #319: [CURATOR-534] Switch to OpenJDK 8 and 11

asfgit merged pull request #319: [CURATOR-534] Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Work logged] (CURATOR-534) Fix Travis-CI config

[ https://issues.apache.org/jira/browse/CURATOR-534?focusedWorklogId=283903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283903 ] ASF GitHub Bot logged work on CURATOR-534: -- Author: ASF GitHub Bot

[jira] [Created] (CURATOR-534) Fix Travis-CI config

Jordan Zimmerman created CURATOR-534: Summary: Fix Travis-CI config Key: CURATOR-534 URL: https://issues.apache.org/jira/browse/CURATOR-534 Project: Apache Curator Issue Type: Improvement

[GitHub] [curator] eolivelli commented on issue #319: Switch to OpenJDK 8 and 11

eolivelli commented on issue #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515778890 @Randgalt build failed with a failed testbut at least now it is working. I have added jdk11 that nowadays it better to have on a CI pipeline and I have tur

[DISCUSS] CURATOR-533

Hi Committers, CURATOR-505 introduced circuit breaking behavior via CircuitBreakingConnectionStateListener and ConnectionStateListenerDecorator. Elastic has been using it with success but reports that the implementation can be improved. The existing implementation uses a new CircuitBreaker for

[jira] [Work logged] (CURATOR-533) Improve CURATOR-505 by making the CircuitBreaker instance shared

[ https://issues.apache.org/jira/browse/CURATOR-533?focusedWorklogId=283902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283902 ] ASF GitHub Bot logged work on CURATOR-533: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt opened a new pull request #320: [CURATOR-533] - introduced circuit breaking behavior

Randgalt opened a new pull request #320: [CURATOR-533] - introduced circuit breaking behavior URL: https://github.com/apache/curator/pull/320 CURATOR-505 introduced circuit breaking behavior via CircuitBreakingConnectionStateListener and ConnectionStateListenerDecorator. Elastic has been

[jira] [Created] (CURATOR-533) Improve CURATOR-505 by making the CircuitBreaker instance shared

Jordan Zimmerman created CURATOR-533: Summary: Improve CURATOR-505 by making the CircuitBreaker instance shared Key: CURATOR-533 URL: https://issues.apache.org/jira/browse/CURATOR-533 Project: Apa

[GitHub] [curator] eolivelli commented on issue #319: Switch to OpenJDK 8 and 11

eolivelli commented on issue #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319#issuecomment-515768753 There is a log of spammy logs: ``` [INFO] --- clirr-maven-plugin:2.8:check (default) @ curator-client --- [INFO] artifact org.apache.curator:curat

Re: master is failing for the last 2 weeks

here it is https://github.com/apache/curator/pull/319 I am trying to add jdk11 as well Enrico Il giorno dom 28 lug 2019 alle ore 09:55 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Let me send a PR, I will play with Travis > PR validation runs with the file on the PR so it is quite simpl

[GitHub] [curator] eolivelli opened a new pull request #319: Switch to OpenJDK 8 and 11

eolivelli opened a new pull request #319: Switch to OpenJDK 8 and 11 URL: https://github.com/apache/curator/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: master is failing for the last 2 weeks

Let me send a PR, I will play with Travis PR validation runs with the file on the PR so it is quite simple, no commiter help needed Enrico Il dom 28 lug 2019, 08:07 Jordan Zimmerman ha scritto: > Yeah - could be - our travis file looks like this: > > language: java >