Re: PROPOSAL: Curator 5.0

2020-03-14 Thread Enrico Olivelli
In your vision, will Curator 5 be compatible with 'simple' applications written for Curator 4? Curator is like Zookeeper, you can end up with having several libraries that rely on it. If we don't keep compatibility in order to update to 5 you need every other library to move to 5 and they won't mov

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403535 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403536 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#discussion_r392640142 ## File path: curator-client/src/main/java/org/apache/curator/utils/Compatibility.java ##

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403532 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403533 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403534 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#discussion_r392640787 ## File path: curator-recipes/src/test/java/org/apache/curator/framework/recipes/leader/TestLe

[GitHub] [curator] TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#discussion_r392640142 ## File path: curator-client/src/main/java/org/apache/curator/utils/Compatibility.java ##

[GitHub] [curator] TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#discussion_r392640840 ## File path: curator-test/src/main/java/org/apache/curator/test/BaseClassForTests.java #

[GitHub] [curator] TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#discussion_r392640705 ## File path: curator-framework/src/main/java/org/apache/curator/framework/imps/ReconfigBuilde

[jira] [Work logged] (CURATOR-549) ZooKeeper 3.6 will add support for Persistent Recursive Watchers - Add Curator support

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-549?focusedWorklogId=403527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403527 ] ASF GitHub Bot logged work on CURATOR-549: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on issue #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0

2020-03-14 Thread GitBox
Randgalt commented on issue #338: [CURATOR-549] Prep for Persistent Watchers by moving to ZK 3.6.0 URL: https://github.com/apache/curator/pull/338#issuecomment-599164345 @shayshim @cammckenzie @TisonKun this PR is ready for review/re-review -

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403512 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt merged pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
Randgalt merged pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: PROPOSAL: Curator 5.0

2020-03-14 Thread shay shimony
Sorry for the late reply. +1 from me too. On Wed, Mar 4, 2020, 04:37 Jordan Zimmerman wrote: > Hi Folks, > > I mentioned this a while back, but now the ZooKeeper 3.6.0 is out I'd like > to make it official. I propose we move to Curator 5.0 and apply a few > non-backward compatible changes - i.e.

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403506 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
Randgalt commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344#discussion_r392623465 ## File path: curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestTreeCache.java ## @

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403502 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344#discussion_r392621920 ## File path: curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestTreeCache.java ## @

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403500 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403501 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344#discussion_r392620988 ## File path: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/PathChildrenCache.java #

[GitHub] [curator] TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344#discussion_r392620893 ## File path: curator-framework/src/main/java/org/apache/curator/framework/listen/MappingListenerManager.java #

[jira] [Work logged] (CURATOR-558) ZooKeeper 3.6.0 has many API changes - bring Curator up to date

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403495 ] ASF GitHub Bot logged work on CURATOR-558: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on issue #344: CURATOR-558 - part 1 of ZK 3.6 updates

2020-03-14 Thread GitBox
Randgalt commented on issue #344: CURATOR-558 - part 1 of ZK 3.6 updates URL: https://github.com/apache/curator/pull/344#issuecomment-599122337 @cammckenzie @shayshim @TisonKun I'm going to merge this unless there is objection. Speak now if you have any concerns. --

[jira] [Resolved] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread Jordan Zimmerman (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-562. -- Assignee: Jordan Zimmerman Resolution: Fixed > Remove ConnectionHandlingPolicy >

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403486 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on issue #349: Upgrade to zookeeper 3.6.0

2020-03-14 Thread GitBox
Randgalt commented on issue #349: Upgrade to zookeeper 3.6.0 URL: https://github.com/apache/curator/pull/349#issuecomment-599112411 We are already working on this in other PRs. Thank you. This is an automated message from the

[GitHub] [curator] Randgalt closed pull request #349: Upgrade to zookeeper 3.6.0

2020-03-14 Thread GitBox
Randgalt closed pull request #349: Upgrade to zookeeper 3.6.0 URL: https://github.com/apache/curator/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403483&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403483 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403484 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403485 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[GitHub] [curator] asfgit closed pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
asfgit closed pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [curator] TisonKun opened a new pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
TisonKun opened a new pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348 See also the description in [JIRA ticket](https://issues.apache.org/jira/browse/CURATOR-562) and commit message of [the last commit](https://github.com/apa

[GitHub] [curator] Randgalt closed pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
Randgalt closed pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [curator] Randgalt commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
Randgalt commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348#issuecomment-599112059 merged This is an automated message from the Apache Git Service. To respond t

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403481 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
TisonKun commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348#issuecomment-599109487 @Randgalt Thanks for your review and PR! I've merged it. This is an automated

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403440 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[GitHub] [curator] Randgalt commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
Randgalt commented on issue #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348#issuecomment-599067855 @TisonKun I sent you a minor PR - other than that I think this is ready This

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403409 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[jira] [Work logged] (CURATOR-562) Remove ConnectionHandlingPolicy

2020-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-562?focusedWorklogId=403408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403408 ] ASF GitHub Bot logged work on CURATOR-562: -- Author: ASF GitHub Bot

[GitHub] [curator] TisonKun commented on a change in pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348#discussion_r392569778 ## File path: curator-client/src/main/java/org/apache/curator/ConnectionState.java ## @@ -18,7 +18,6 @@

[GitHub] [curator] TisonKun commented on a change in pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy

2020-03-14 Thread GitBox
TisonKun commented on a change in pull request #348: CURATOR-562 Remove ConnectionHandlingPolicy URL: https://github.com/apache/curator/pull/348#discussion_r392569778 ## File path: curator-client/src/main/java/org/apache/curator/ConnectionState.java ## @@ -18,7 +18,6 @@