[jira] [Work logged] (CURATOR-653) Double leader for LeaderLatch

2022-09-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-653?focusedWorklogId=813330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813330 ] ASF GitHub Bot logged work on CURATOR-653: -- Author: ASF GitHub Bot

[GitHub] [curator] eolivelli commented on pull request #398: CURATOR-653: fix potential double leader for LeaderLatch

2022-09-29 Thread GitBox
eolivelli commented on PR #398: URL: https://github.com/apache/curator/pull/398#issuecomment-1262293140 @tisonkun thanks for fixing the test @woaishixiaoxiao do you agree with @tisonkun 's fix ? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: Next 5.4.0 release ?

2022-09-29 Thread tison
Hi Enrico, Thanks for starting this discussion. +1 for a new releease. I'll pick up one patch to see if we can include in the release https://github.com/apache/curator/pull/398. See also my last comment there. Best, tison. Enrico Olivelli 于2022年9月29日周四 20:50写道: > Hello, > Is there any show s

[jira] [Work logged] (CURATOR-653) Double leader for LeaderLatch

2022-09-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CURATOR-653?focusedWorklogId=813329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813329 ] ASF GitHub Bot logged work on CURATOR-653: -- Author: ASF GitHub Bot

[GitHub] [curator] tisonkun commented on pull request #398: CURATOR-653: fix potential double leader for LeaderLatch

2022-09-29 Thread GitBox
tisonkun commented on PR #398: URL: https://github.com/apache/curator/pull/398#issuecomment-1262277533 I adjust the test to inject force `reset`s instead of depending on connection loss. Although this means it should be a non-real-world case now, I still agree on `setLeadership(false)` on `

Next 5.4.0 release ?

2022-09-29 Thread Enrico Olivelli
Hello, Is there any show stopper for a new 5.4.0 release ? We have many goodies, like supporting ZookKeeper 3.7.1 and use ZookKeeperServerEmbedded. if no-one objects I will start a release in the next days Best regards Enrico