[GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...

2016-08-30 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/161 Looks good to me, thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...

2016-08-30 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/curator/pull/161 thanks for the feedback. I fixed up the unit test to make it more deterministic. Changed the watcher to do an update and notification in the background. That sorts my use case however the u

[GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...

2016-08-28 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/161 I'm not sure on the pattern for executors, probably just the whim of whoever implemented the recipe I imagine. I think that you should be able to do this asynchronously without an execu

[GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...

2016-08-25 Thread gtully
Github user gtully commented on the issue: https://github.com/apache/curator/pull/161 Thanks for taking the time to peek at this. I agree. Doing everything async will make it a little heaver weight but I think it is more correct. There seems to be be some recipes that take ex

[GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...

2016-08-24 Thread cammckenzie
Github user cammckenzie commented on the issue: https://github.com/apache/curator/pull/161 I don't think that this completely fixes the problem. The test fails intermittently because it's possible that the server gets stopped while the SharedValue is processing the initial connected e