Github user madrob closed the pull request at:
https://github.com/apache/curator/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/88#issuecomment-134171096
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/88#issuecomment-122622144
Agree that this is old code that should be stable. Do you have a specific
scenario/test case that you think this would cause issue with, or is it "gut
feeling?"
---
If
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/88#issuecomment-122571772
I'm looking at this very carefully. It makes sense but this is old old code
and deep deep in the heart of things. We should proceed with caution.
---
If your project i
Github user madrob commented on a diff in the pull request:
https://github.com/apache/curator/pull/88#discussion_r34185266
--- Diff:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestBlockUntilConnected.java
---
@@ -232,4 +232,30 @@ public void run()
Github user dragonsinth commented on the pull request:
https://github.com/apache/curator/pull/88#issuecomment-119695849
Remove the TreeCache changes? Seems unrelated to the underlying bug in
retrospect.
---
If your project is set up for it, you can reply to this email and have your
Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/88#discussion_r34184613
--- Diff:
curator-framework/src/test/java/org/apache/curator/framework/imps/TestBlockUntilConnected.java
---
@@ -232,4 +232,30 @@ public void run()
GitHub user madrob opened a pull request:
https://github.com/apache/curator/pull/88
CURATOR-218 Reorder ConnectionState process event
Address a race condition in ConnectionState.process where it will
trigger watchers first before updating its own state. This can lead to
incon
