[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251851979 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -610,18 +610,18 @@ private String

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251685066 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251684425 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread cammckenzie
Github user cammckenzie commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251672915 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java --- @@ -48,19 +50,21 @@ public class

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251599266 --- Diff: curator-client/src/main/java/org/apache/curator/utils/InjectSessionExpiration.java --- @@ -94,7 +89,7 @@ public static void

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread shayshim
Github user shayshim commented on a diff in the pull request: https://github.com/apache/curator/pull/303#discussion_r251593572 --- Diff: curator-client/src/main/java/org/apache/curator/utils/InjectSessionExpiration.java --- @@ -94,7 +89,7 @@ public static void

[GitHub] curator pull request #303: [CURATOR-498] Protected Mode creation can mistake...

2019-01-28 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/curator/pull/303 [CURATOR-498] Protected Mode creation can mistake closing session's node causing problems for many recipes such as LeaderLatch Kudos to user Shay Shimony for his tireless and excellent work