Re: New Java 9 master

2017-11-15 Thread Christian Schneider
I dont think we can already predict when users move to Java 9. So creating a Java 9 only branch at this time means we have to maintain two main branches over a long time. What is the rationale behind a Java 9 only branch compared to being Java 9 and Java 8 compatible on master? Christian 2017-11

Re: New Java 9 master

2017-11-15 Thread Freeman Fang
+1 If next CXF major release(3.3 or 4.0) are not going to support JDK8 anymore, it’s about the time to create master branch which is for Java9(and the successor JDK version which is not very far away). And this also would be easy for us to adjust CXF to use the jigsaw module eventually, like to

Re: New Java 9 master

2017-11-15 Thread Andy McCright
Hi Sergey, I'm in favor of the idea. One thing worth noting is that Java 9 is a very limited support release. According to Oracle's support strategy [1], Java 9 will only be supported until March 2018, then they will be releasing Java 10 (aka 18.3) which also will have a short shelf-life. The n

Re: Remove obsolete RxJava code and keep RxJava2 only one

2017-11-15 Thread Andriy Redko
Hey Sergey, That would be ideal I think (move RxJava into separate module). RxJava2 and RxJava are quite different frameworks, some people just stuck with RxJava so we could support them there. Thanks. Best Regards, Andriy Redko JDA> What about just leaving the old RxJava code in a module by

Re: Remove obsolete RxJava code and keep RxJava2 only one

2017-11-15 Thread Sergey Beryozkin
Hi, Indeed, creating a new module specifically for RxJava is technically clean, but creating it for a code which no one will probably use and also adding one module to the large number of CXF modules, with only 2/3 Java files :-) is a bit problematic... I guess I can keep it as is in 3.2.x b

Re: Remove obsolete RxJava code and keep RxJava2 only one

2017-11-15 Thread John D. Ament
What about just leaving the old RxJava code in a module by itself (when I was looking recently, it didn't make much sense to see both RxJava and RxJava2 in one module). On Wed, Nov 15, 2017 at 10:56 AM Sergey Beryozkin wrote: > Hi > > cxf-rt-rs-extension-rx ships the code for both (old) RxJava a

Remove obsolete RxJava code and keep RxJava2 only one

2017-11-15 Thread Sergey Beryozkin
Hi cxf-rt-rs-extension-rx ships the code for both (old) RxJava and RxJava2 code. It supports returning RxJava2 Flowable and Observable on the server and accepting it on the client, and the same for the (old) RxJava Observable... While even the (old) RxJava code is very new for CXF, the realit

[GitHub] sberyozkin commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans

2017-11-15 Thread GitBox
sberyozkin commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344625021 Not my fault this PR has been closed :-) This is an auto

[GitHub] reta closed pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans

2017-11-15 Thread GitBox
reta closed pull request #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans

2017-11-15 Thread GitBox
reta commented on issue #339: CXF-7544: Support @Context-based injection into proxied CDI beans URL: https://github.com/apache/cxf/pull/339#issuecomment-344591904 Better solution is required, closing This is an automated mes

New Java 9 master

2017-11-15 Thread Sergey Beryozkin
Hi Should we open a new Java 9 only master soon enough ? Thanks, Sergey

[GitHub] forsthofer commented on a change in pull request #340: [CXF-7562] correction for truncated flag

2017-11-15 Thread GitBox
forsthofer commented on a change in pull request #340: [CXF-7562] correction for truncated flag URL: https://github.com/apache/cxf/pull/340#discussion_r151102002 ## File path: rt/features/logging/src/main/java/org/apache/cxf/ext/logging/LoggingOutInterceptor.java ## @@ -8