Re: Increase CXF PR Builder timeout?

2017-12-20 Thread John D. Ament
I spoke with Gav. I recommended to him to first try a no activity check. The build will time out if it was idle for 5 minutes. If that works worse or causes other issues we'll do an absolute again at a higher value as mentioned. John On Wed, Dec 20, 2017 at 8:46 PM Andriy Redko

[GitHub] johnament commented on a change in pull request #351: [CXF-7571] Adding support for CDI injection of @Context objects.

2017-12-20 Thread GitBox
johnament commented on a change in pull request #351: [CXF-7571] Adding support for CDI injection of @Context objects. URL: https://github.com/apache/cxf/pull/351#discussion_r158187709 ## File path: integration/cdi/src/main/java/org/apache/cxf/cdi/DelegateContextAnnotatedType.java

Re: Increase CXF PR Builder timeout?

2017-12-20 Thread Andriy Redko
I have checked the last couple of builds (non PR ones), we are very close to 90 minutes mark there. I think it would be good to give the builds a bit of breathing by increasing the timeout to 100-120 minutes. Best Regards, Andriy Redko JDA> I've noticed the last couple of PRs have timed out

Re: Default Priority for built in providers

2017-12-20 Thread John D. Ament
Sergey, Agreed, yes that's the current confusing part. The problem is that the 500x default behavior is what's surprising to some users (having implemented it in CXF and other JAX-RS runtimes and received internal user feedback on what is and isn't working). Granted, most devs don't read the

Increase CXF PR Builder timeout?

2017-12-20 Thread John D. Ament
I've noticed the last couple of PRs have timed out before build completing. The current build cap is at 90 minutes. It takes 10 minutes to do the initial project build in the PR job, so I'm assuming it's taking over 80 minutes for the testing phase. I believe infra has a preference to ensure

[GitHub] johnament closed pull request #359: Adding an implementation of the MicroProfile Rest Client v1.0

2017-12-20 Thread GitBox
johnament closed pull request #359: Adding an implementation of the MicroProfile Rest Client v1.0 URL: https://github.com/apache/cxf/pull/359 This is an automated message from the Apache Git Service. To respond to the

[GitHub] johnament commented on issue #359: Adding an implementation of the MicroProfile Rest Client v1.0

2017-12-20 Thread GitBox
johnament commented on issue #359: Adding an implementation of the MicroProfile Rest Client v1.0 URL: https://github.com/apache/cxf/pull/359#issuecomment-353058326 My plan is to merge this branch into master later today, since I'm way too far off master at this point. I'll address any

[GitHub] johnament closed pull request #360: MP Rest Client interface validation and tests

2017-12-20 Thread GitBox
johnament closed pull request #360: MP Rest Client interface validation and tests URL: https://github.com/apache/cxf/pull/360 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

Re: Default Priority for built in providers

2017-12-20 Thread Sergey Beryozkin
Hi John On 20/12/17 02:47, John D. Ament wrote: The only concrete case I can think of is when someone registers a MBR/MBW with annotation priority of 5002 and up. In this case, the CXF provider will take precedence. But as I understand the spec, the user defined provider should always take