[GitHub] johnament commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService

johnament commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService URL: https://github.com/apache/cxf/pull/368#issuecomment-359132180 @andymc12 I kind of agree with @reta (but for a slightly different reason I think..), since we're using the static

[GitHub] reta commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService

reta commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService URL: https://github.com/apache/cxf/pull/368#issuecomment-359123288 @andymc12 I don't think this is a problem we need to solve, this is how `CompletableFuture` works, and I believe the

[GitHub] reta commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService

reta commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService URL: https://github.com/apache/cxf/pull/368#issuecomment-359123288 @andymc12 I don't think this is a problem we need to solve, this is how `CompletableFuture` works, and I believe the

[GitHub] andymc12 commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService

andymc12 commented on issue #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService URL: https://github.com/apache/cxf/pull/368#issuecomment-359121199 Looking at this a little more, this is not a complete solution... This will work for the _next_ stage, but not

[GitHub] andymc12 opened a new pull request #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService

andymc12 opened a new pull request #368: Ensure that the JAX-RS CompletionStage uses the correct ExecutorService URL: https://github.com/apache/cxf/pull/368 Clients can specify an ExecutorService via the property() method, but currently, that ES is only used for the initial rx() method.

Re: New Logging interceptors

Instead of the interceptors you should use the new LoggingFeature. It will make sure the interceptors are correctly wired. If you use it like this then the system property is not required. See http://cxf.apache.org/docs/message-logging.html Christian 2018-01-19 11:56 GMT+01:00 Colm O

Re: New Logging interceptors

May be that property was already set somewhere to false, hence reseting it to true made a diff, might be worth debugging what isLoggingDisabledNow returns... Sergey On 19/01/18 11:20, Colm O hEigeartaigh wrote: In a test I was working with, message logging only worked when I added the new

Re: New Logging interceptors

In a test I was working with, message logging only worked when I added the new interceptors to the interceptor chain if I explicitly set the system property to "true". Otherwise nothing was logged. Colm. On Fri, Jan 19, 2018 at 11:15 AM, Sergey Beryozkin wrote: > It can

Re: New Logging interceptors

It can only be used to disable the logging if it is explicitly set and is false: https://github.com/apache/cxf/blob/master/rt/features/logging/src/main/java/org/apache/cxf/ext/logging/AbstractLoggingInterceptor.java#L49 Sergey On 19/01/18 11:09, Colm O hEigeartaigh wrote: I don't see

Re: New Logging interceptors

I don't see "org.apache.cxf.logging.enabled" set anywhere in the systests or is it enabled a different way? Colm. On Fri, Jan 19, 2018 at 11:00 AM, Sergey Beryozkin wrote: > These new interceptors are used in systests, no problems. > That property is used to switch the

Re: New Logging interceptors

These new interceptors are used in systests, no problems. That property is used to switch the logging on/off dynamically... Cheers, Sergey On 19/01/18 10:56, Colm O hEigeartaigh wrote: Hi all, With the old logging interceptors in CXF core (org.apache.cxf.interceptor) you just had to attach

New Logging interceptors

Hi all, With the old logging interceptors in CXF core (org.apache.cxf.interceptor) you just had to attach them to the interceptor chain to see the outbound/inbound requests. These interceptors are now deprecated. However in the new interceptors (org.apache.cxf.ext.logging), attaching them to the