[GitHub] andymc12 commented on issue #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
andymc12 commented on issue #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#issuecomment-362484490 And one more TCK fix. CXF was failing with a ClassCastException when the TCK added a new non-String object header in a ClientRequestFilter. CXF converts these

[GitHub] andymc12 commented on issue #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
andymc12 commented on issue #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#issuecomment-362481200 I added a new commit. Some SSE systests were failing because the SSE code was calling `builder.headers(...)` which was clobbering some required headers. This commit

[GitHub] ffang closed pull request #375: [CXF-7628] Enable JMX threading parameters for cxf endpoints in blueprint.

2018-02-01 Thread GitBox
ffang closed pull request #375: [CXF-7628] Enable JMX threading parameters for cxf endpoints in blueprint. URL: https://github.com/apache/cxf/pull/375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] andymc12 commented on a change in pull request #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
andymc12 commented on a change in pull request #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#discussion_r165452522 ## File path: rt/transports/http/src/main/java/org/apache/cxf/transport/http/Headers.java ## @@ -588,9 +589,10 @@ public static

[GitHub] andymc12 commented on a change in pull request #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
andymc12 commented on a change in pull request #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#discussion_r165451479 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/spec/InvocationBuilderImpl.java ## @@ -253,10 +253,13 @@

[GitHub] johnament commented on a change in pull request #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
johnament commented on a change in pull request #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#discussion_r165429936 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/spec/InvocationBuilderImpl.java ## @@ -253,10 +253,13 @@

[GitHub] 1984shekhar opened a new pull request #375: [CXF-7628] Enable JMX threading parameters for cxf endpoints in blueprint.

2018-02-01 Thread GitBox
1984shekhar opened a new pull request #375: [CXF-7628] Enable JMX threading parameters for cxf endpoints in blueprint. URL: https://github.com/apache/cxf/pull/375 Enable JMX connector and ThreadingParameters mbean for cxf webservice created with custom threading parameters in

[GitHub] andymc12 commented on issue #373: JAX-RS 2.1 TCK issues

2018-02-01 Thread GitBox
andymc12 commented on issue #373: JAX-RS 2.1 TCK issues URL: https://github.com/apache/cxf/pull/373#issuecomment-362296701 @sberyozkin I agree with your update. I'm not sure whether the clone is required for somewhere else though. I figured the safest thing was a new method to clear the

[GitHub] 1984shekhar closed pull request #374: [CXF-7628]

2018-02-01 Thread GitBox
1984shekhar closed pull request #374: [CXF-7628] URL: https://github.com/apache/cxf/pull/374 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the

[GitHub] 1984shekhar commented on issue #374: [CXF-7628]

2018-02-01 Thread GitBox
1984shekhar commented on issue #374: [CXF-7628] URL: https://github.com/apache/cxf/pull/374#issuecomment-362290187 There are multiple commit which are unnecessary. This is an automated message from the Apache Git Service. To

[GitHub] 1984shekhar opened a new pull request #374: [CXF-7628]

2018-02-01 Thread GitBox
1984shekhar opened a new pull request #374: [CXF-7628] URL: https://github.com/apache/cxf/pull/374 Enable JMX connector and threading-parameters mbeans for endpoints with custom threading parameters configured in blueprint xml.

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
Hi Dennis Np, sometimes I miss the failures as well :-). As I said earlier, it looks like 1.5.18 went to a pre 1.5.16 model. The Swagger 2 to Open Api conversion test does pass with 1.5.18 in 3.1.x but note the conversion filter is diff betweem 3.1.x and the master; in 3.1.x, in

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Dennis Kieselhorst
Hi Sergey, my bad I wasn't able to run all tests locally. The ServerLauncher class produces a long classpath resulting in CreateProcess error=206 on my current environment. In general it looked fine and I thought Jenkins will run the testcases as well. So let's use 1.5.17 for 3.2.2 and I'll

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
FYI, that jenkins job did not reach these tests: [INFO] Apache CXF JAX-RS System Tests . SKIPPED On 01/02/18 14:24, Sergey Beryozkin wrote: Hi Dennis All related tests in systests/jaxrs fail if I run then directly from systests/jaxrs: [ERROR] Errors: [ERROR]

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
Hi Dennis All related tests in systests/jaxrs fail if I run then directly from systests/jaxrs: [ERROR] Errors: [ERROR]

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
Hi Dennis All Swagger 2 tests in systests/jaxrs... Let me rebuild everything and try again Thanks, Sergey On 01/02/18 14:04, Dennis Kieselhorst wrote: Hi Sergey, which tests are failing for you? I don't see any related test failures here:

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Dennis Kieselhorst
Hi Sergey, which tests are failing for you? I don't see any related test failures here: https://builds.apache.org/view/A-D/view/CXF/job/CXF-Trunk-JDK18/lastCompletedBuild/testReport/ They fixed pretty print (https://github.com/swagger-api/swagger-core/issues/2320) and read only properties

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
I've reverted back to 1.5.17 as I see systests failing with it. FYI, tests pass OK with 1.5.18 in 3.1.x which stayed at 1.5.12. In 3.1.x we retained the the same feature code but on the master, when upgrading to 1.5.16 (?) we had to change that as the same model did nnot work anymore. Now it

Re: [cxf] branch master updated: update swagger-core to latest version

2018-02-01 Thread Sergey Beryozkin
Hi Dennis We were looking with Francesco at this version and saw some issues, do systest/jaxrs tests pass for you ? Thanks, Sergey On 01/02/18 09:30, d...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. deki pushed a commit to branch master in