[GitHub] reta commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

reta commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-448040811 hey @andymc12 , sorry was crazy day at work, yeah I think we could create dedicated class/interface, like `ClientProperties` and move these common

[GitHub] andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-447964089 @reta - Thanks so much for the thorough review! I've updated the PR with a new commit (Code review comments) that addresses everything you

[GitHub] amarkevich closed pull request #483: HttpHeaderHelper: String.replace instead of Pattern.matcher().replaceAll

amarkevich closed pull request #483: HttpHeaderHelper: String.replace instead of Pattern.matcher().replaceAll URL: https://github.com/apache/cxf/pull/483 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coheigea commented on a change in pull request #483: HttpHeaderHelper: String.replace instead of Pattern.matcher().replaceAll

coheigea commented on a change in pull request #483: HttpHeaderHelper: String.replace instead of Pattern.matcher().replaceAll URL: https://github.com/apache/cxf/pull/483#discussion_r242243934 ## File path: core/src/main/java/org/apache/cxf/helpers/HttpHeaderHelper.java ##

Re: CXF 3.1.18 release

I'm planning to call a vote this week - is there anything else anyone wants to see in 3.1.x? Colm. On Fri, Dec 7, 2018 at 6:29 AM Jim Ma wrote: > +1 > > On Mon, Dec 3, 2018 at 5:54 PM Colm O hEigeartaigh > wrote: > >> OK fair enough. I propose that this might be the last release of 3.1.x >>

[GitHub] andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl

andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#discussion_r24843 ## File path:

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242219947 ## File path: rt/rs/security/http-signature/src/test/java/org/apache/cxf/rs/security/httpsignature/MessageVerifierTest.java ## @@ -0,0 +1,217 @@

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242217342 ## File path: rt/rs/security/http-signature/pom.xml ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242220268 ## File path: rt/rs/security/http-signature/src/test/java/org/apache/cxf/rs/security/httpsignature/exception/DifferentAlgorithmsException.java ##

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242219440 ## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/SignatureHeaderUtils.java ## @@ -0,0 +1,118 @@

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242217615 ## File path: rt/rs/security/http-signature/pom.xml ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242217046 ## File path: rt/rs/security/http-signature/pom.xml ## @@ -0,0 +1,74 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242219313 ## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/SignatureHeaderUtils.java ## @@ -0,0 +1,118 @@

[GitHub] coheigea commented on a change in pull request #462: Httpsig

coheigea commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r242218999 ## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/MessageVerifier.java ## @@ -0,0 +1,245 @@ +/**

[GitHub] andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl

andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#discussion_r242210437 ## File path: rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/CxfTypeSafeClientBuilder.java

[GitHub] andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl

andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#discussion_r242209204 ## File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/spec/ClientImpl.java ## @@ -52,8 +52,8

[GitHub] andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl

andymc12 commented on a change in pull request #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#discussion_r242191278 ## File path: rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/CxfTypeSafeClientBuilder.java