jimma merged PR #937:
URL: https://github.com/apache/cxf/pull/937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For
Thanks Freeman. I updated my PRs to remove this profile completely from CXF
3.4.x to 4.x. Please review.
On Thu, Apr 21, 2022 at 9:45 PM Freeman Fang wrote:
> Hi Jim,
>
> I took another look, we actually don't need JVM option
> --add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED
> to build
reta commented on code in PR #940:
URL: https://github.com/apache/cxf/pull/940#discussion_r855677308
##
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
reta commented on code in PR #940:
URL: https://github.com/apache/cxf/pull/940#discussion_r855677308
##
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
Hi Jim,
I took another look, we actually don't need JVM option
--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED
to build CXF management module with JDK 9+, because CXF management module
now doesn't use JDK internal API sun.rmi.registry anymore(CXF-8250 made
this change). So we don't need it
I think we can remove this profile from 3.4.x and 3.5.x too. There is no
reason we should still keep this, right ?
I tried to build 3.4.x/3.5.x with jdk11, and the Export-Package entry in
META-INF is generated as expected.
On Thu, Apr 21, 2022 at 10:25 AM Freeman Fang
wrote:
> Hi Jim,
>
> I