Re: [VOTE] Apache CXF 3.5.3 and 3.4.8

2022-06-24 Thread Jean-Baptiste Onofré
+1 (non binding) Regards JB On Fri, Jun 24, 2022 at 6:18 PM Daniel Kulp wrote: > > > > This is a vote to release the latest set of patches for CXF. > > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachecxf-1180/ >

Re: [VOTE] Apache CXF 3.5.3 and 3.4.8

2022-06-24 Thread Alexey Markevich
+1 On 6/24/22, Daniel Kulp wrote: > > > This is a vote to release the latest set of patches for CXF. > > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachecxf-1180/ > > https://repository.a

[GitHub] [cxf] reta commented on pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-06-24 Thread GitBox
reta commented on PR #960: URL: https://github.com/apache/cxf/pull/960#issuecomment-1165839824 @dkulp relied on `isXOPPackage()` flag of the `AttachmentUnmarshaller` to distinguish xop / non-xop cases, what do you think of it? Thank you! -- This is an automated message from the Apache Git

[GitHub] [cxf] reta commented on pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-06-24 Thread GitBox
reta commented on PR #960: URL: https://github.com/apache/cxf/pull/960#issuecomment-1165811077 > The main issue is that SOAP w/ Attachments doesn't have that limitation. Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed in to enable/disa

[GitHub] [cxf] dkulp commented on pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-06-24 Thread GitBox
dkulp commented on PR #960: URL: https://github.com/apache/cxf/pull/960#issuecomment-1165803308 The main issue is that SOAP w/ Attachments doesn't have that limitation. Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed in to enable/disa

[GitHub] [cxf] reta commented on pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-06-24 Thread GitBox
reta commented on PR #960: URL: https://github.com/apache/cxf/pull/960#issuecomment-1165795132 > Thus, I think the better fix would be to pass a flag into LazyDataSource to allow flipping to URLDataSource if the CID isn't present as a direct attachment. @dkulp thanks, I think I got y

Re: [VOTE] Apache CXF 3.5.3 and 3.4.8

2022-06-24 Thread Jeff Genender
+1 Jeff > On Jun 24, 2022, at 10:18 AM, Daniel Kulp wrote: > > > > This is a vote to release the latest set of patches for CXF. > > > Staging repositories: > https://repository.apache.org/content/repositories/orgapachecxf-1180/ >

Re: [VOTE] Apache CXF 3.5.3 and 3.4.8

2022-06-24 Thread Andriy Redko
+1, thanks Dan! Best Regards, Andriy Redko > This is a vote to release the latest set of patches for CXF.  > Staging repositories: > https://repository.apache.org/content/repositories/orgapachecxf-1180/  > > https://rep

[VOTE] Apache CXF 3.5.3 and 3.4.8

2022-06-24 Thread Daniel Kulp
This is a vote to release the latest set of patches for CXF. Staging repositories: https://repository.apache.org/content/repositories/orgapachecxf-1180/ https://repository.apache.org/content/repositories/orgapachecxf-1181

[GitHub] [cxf] dkulp commented on pull request #960: CXF-8706: CXF MTOM handler allow content injection

2022-06-24 Thread GitBox
dkulp commented on PR #960: URL: https://github.com/apache/cxf/pull/960#issuecomment-1165607079 I don't think this is the "right" fix for this. The Soap w/ Attachement spec allows for http URL's for the cid and actually shows that use in the examples ( https://www.w3.org/TR/SOAP-attachmen