Re: [PR] [CXF-9023] Increase unit test coverage on org.apache.cxf.bus [cxf]

reta commented on code in PR #1901: URL: https://github.com/apache/cxf/pull/1901#discussion_r1645107739 ## core/src/test/java/org/apache/cxf/bus/managers/ClientLifeCycleManagerImplTest.java: ## Review Comment: ![image](https://github.com/apache/cxf/assets/509855/19cc5b13-6

Re: [PR] [CXF-9023] Increase unit test coverage on org.apache.cxf.bus [cxf]

reta commented on code in PR #1901: URL: https://github.com/apache/cxf/pull/1901#discussion_r1645104187 ## core/src/test/java/org/apache/cxf/bus/ManagedBusTest.java: ## Review Comment: ![image](https://github.com/apache/cxf/assets/509855/b6187402-63a4-4e25-aef6-667e9bb3139

Re: [PR] CXF-9007: NullPointerException in XMLStreamDataWriter.writeNode [cxf]

reta merged PR #1861: URL: https://github.com/apache/cxf/pull/1861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] [CXF-9030] suppress date on '@Generated' when set [cxf]

bmarwell commented on PR #1929: URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176348193 Oh it's probably because of matcher.matches which checks for the whole line to match exactly. I think it should have been .find instead. Will check at home later -- This is an auto

Re: [PR] [CXF-9030] suppress date on '@Generated' when set [cxf]

reta commented on PR #1929: URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176256297 ``` java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53)

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.5 to 3.3.0 [cxf]

reta merged PR #1927: URL: https://github.com/apache/cxf/pull/1927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-report-plugin from 3.2.5 to 3.3.0 [cxf]

reta merged PR #1928: URL: https://github.com/apache/cxf/pull/1928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For q

Re: [PR] [CXF-9030] suppress date on '@Generated' when set [cxf]

reta commented on PR #1929: URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176009364 Thanks for the fix, @bmarwell , could you please update `CodeGenOptionTest::testSuppressGeneratedDatePresentOption` to assert that the `@Generated` annotation has no date? Thank you. -- This

[PR] [CXF-9030] suppress date on '@Generated' when set [cxf]

bmarwell opened a new pull request, #1929: URL: https://github.com/apache/cxf/pull/1929 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: