[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-30 Thread GitBox
aziubin commented on PR #1033: URL: https://github.com/apache/cxf/pull/1033#issuecomment-1331969825 @reta thanks. I have verified that last change and it work OK for me too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-29 Thread GitBox
aziubin commented on PR #1033: URL: https://github.com/apache/cxf/pull/1033#issuecomment-1331034447 @reta looks good. I tested new fix in my environment and it works well. There is one thing, which I wanted to discuss with you. The `MessageContentsList(List values)` constructor can be used

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-26 Thread GitBox
aziubin commented on PR #1033: URL: https://github.com/apache/cxf/pull/1033#issuecomment-1328035372 > @aziubin do you mind if push a few changes to your pull request? I would like to add tests and share an idea that does not use `REMOVED_MARKER` in the first place (but preserving the

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-24 Thread GitBox
aziubin commented on PR #1033: URL: https://github.com/apache/cxf/pull/1033#issuecomment-1326759798 > Thanks @aziubin , the `MessageContentsList` is very widely used with CXF and may be outside (since this is a public class), so none of the "isolated, safe and will not have negative impact

[GitHub] [cxf] aziubin commented on pull request #1033: CXF-8796: Replace REMOVED_MARKER with null

2022-11-23 Thread GitBox
aziubin commented on PR #1033: URL: https://github.com/apache/cxf/pull/1033#issuecomment-1325250610 Hi @reta, thank you too for reproducing this issue and looking at code changes. The case when the last argument is omitted is not covered. The "argument type mismatch while invoking" error