[GitHub] [cxf] coheigea commented on a diff in pull request #927: Merge Opensaml4 to Jakarta EE branch

2022-04-05 Thread GitBox
coheigea commented on code in PR #927: URL: https://github.com/apache/cxf/pull/927#discussion_r842447167 ## services/pom.xml: ## @@ -34,6 +34,16 @@ sts wsn ws-discovery -xkms Review Comment: @reta It's only xkms/itests that needs to be excl

[GitHub] [cxf] coheigea commented on a diff in pull request #927: Merge Opensaml4 to Jakarta EE branch

2022-04-04 Thread GitBox
coheigea commented on code in PR #927: URL: https://github.com/apache/cxf/pull/927#discussion_r841420852 ## rt/rs/security/oauth-parent/oauth2-saml/src/main/java/org/apache/cxf/rs/security/oauth2/saml/SamlOAuthValidator.java: ## @@ -144,7 +145,7 @@ private void validateSubjectCo

[GitHub] [cxf] coheigea commented on a diff in pull request #927: Merge Opensaml4 to Jakarta EE branch

2022-04-03 Thread GitBox
coheigea commented on code in PR #927: URL: https://github.com/apache/cxf/pull/927#discussion_r841416934 ## rt/rs/security/oauth-parent/oauth2-saml/src/main/java/org/apache/cxf/rs/security/oauth2/saml/SamlOAuthValidator.java: ## @@ -144,7 +145,7 @@ private void validateSubjectCo