[GitHub] andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

2019-01-04 Thread GitBox
andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-451561607 Per discussion in Google Chat, this (suggestion 2) fails in OWB but can work in Weld. For now, I'll plan to merge this as-is - then (after OWB is

[GitHub] andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

2019-01-03 Thread GitBox
andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-451303175 Happy New Year @rmannibucau! And thanks - that helps a lot! I've updated the code to use CDI AnnotatedTypes which should address your

[GitHub] andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

2018-12-18 Thread GitBox
andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-448328679 @reta I introduced a new `ClientProperties` interface with all of the properties from `ClientImpl` - afaict, only the timeout-based properties are

[GitHub] andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl

2018-12-17 Thread GitBox
andymc12 commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-447964089 @reta - Thanks so much for the thorough review! I've updated the PR with a new commit (Code review comments) that addresses everything you