Re: [cxf] branch master updated: [CXF-7934]Add cache for ProxyClassLoader

Never mind… I see you already did yesterday. I’m a bit behind. :) Thanks! Dan > On Jan 15, 2019, at 6:30 PM, Daniel Kulp wrote: > > Freeman, > > This looks much better. Can you get this merged in? Thanks! > > Dan > > >> On Dec 24, 2018, at 4:50 AM, Freeman Fang >

Re: [cxf] branch master updated: [CXF-7934]Add cache for ProxyClassLoader

Freeman, This looks much better. Can you get this merged in? Thanks! Dan > On Dec 24, 2018, at 4:50 AM, Freeman Fang wrote: > > Hi Dan, > > I just revised to use ClassValue as ProxyClassLoaderCache backend, and I > pushed the changes to ProxyClassLoaderCache branch, would you please take

Re: [cxf] branch master updated: [CXF-7934]Add cache for ProxyClassLoader

Hi Dan, I just revised to use ClassValue as ProxyClassLoaderCache backend, and I pushed the changes to ProxyClassLoaderCache branch, would you please take a look? Merry Christmas! － Freeman(Yue) Fang Red Hat, Inc. > On Dec 21, 2018, at 11:43 PM, Daniel Kulp wrote: > > This c

Re: [cxf] branch master updated: [CXF-7934]Add cache for ProxyClassLoader

Thanks Dan! I’m looking at the ClassValue way now, will get back to you soon. － Freeman(Yue) Fang Red Hat, Inc. > On Dec 21, 2018, at 11:43 PM, Daniel Kulp wrote: > > This commit has a bunch of problems. > > At no point is anything removed from these caches until the cache

Re: [cxf] branch master updated: [CXF-7934]Add cache for ProxyClassLoader

This commit has a bunch of problems. At no point is anything removed from these caches until the cache fills. Thus, would definitely be considered a memory leak of some sort. Also, because the class loader is held onto strongly, the classes are locked and not able to be garbage collected.