Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-04-17 Thread Colm O hEigeartaigh
Hey Andriy, I think it's what I said on the PR, that the Jakarta profile in the root pom doesn't have the Apache snapshot repo to get the WSS4J SNAPSHOTs. Colm. On Sun, Apr 17, 2022 at 3:21 PM Andriy Redko wrote: > > Hey Jim, Colm, > > I merged the Opensaml + WSSJ4 changes [1] into the Jakarta

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-04-17 Thread Andriy Redko
Hey Jim, Colm, I merged the Opensaml + WSSJ4 changes [1] into the Jakarta branch [2], there is still an issue with non-existing artifact(s): [ERROR] Failed to execute goal on project cxf-rt-security-saml: Could not resolve dependencies for project

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-28 Thread Jim Ma
Thanks for the merge, Andriy. I just checked this test with this merge, I still get the same failure. On Sat, Mar 26, 2022 at 11:46 PM Andriy Redko wrote: > Hey Jim, Colm, > > I have created this pull request [1] to merge changes from OpenSaml4 to > Jakarta > branch, looks like everything is

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-26 Thread Andriy Redko
Hey Jim, Colm, I have created this pull request [1] to merge changes from OpenSaml4 to Jakarta branch, looks like everything is in, @Colm could you please take a look? Thank you! [1] https://github.com/apache/cxf/pull/927/files JM> Hi Colm, JM> You are right. My working branch missed several

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-24 Thread Andriy Redko
Hey Colm, Yeah, sure, I could open the pull request to incorporate opensaml4 changes, will ping you shortly, thanks! PS: The Jakarta branch is open against origin [1], so if you need to push any fixes or changes - you could do that anytime :-) https://github.com/apache/cxf/tree/CXF-8371

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-24 Thread Jim Ma
Hi Colm, You are right. My working branch missed several commits. This is a good idea to merge these missed things to jakarta branch. I'll have a test again after @Andriy Redko merge these changes. Thanks, Jim On Thu, Mar 24, 2022 at 4:31 PM Colm O hEigeartaigh wrote: > Hi Jim, > > Your

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-24 Thread Colm O hEigeartaigh
Hi Jim, Your branch is behind CXF master with regards several commits. I think it would be better if we just worked off one official branch at CXF. @Andriy Redko maybe we should just incorporate https://github.com/apache/cxf/tree/opensaml4 into your Jakarta branch so that I can look at what's

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-23 Thread Jim Ma
Thanks for the quick fix, Colm. It seems there is another failure under services/sts/systests/advanced: [INFO] Running org.apache.cxf.systest.sts.renew.SAMLRenewTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.297 s <<< FAILURE! - in

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-23 Thread Colm O hEigeartaigh
The SAML failures were caused by a hard-coded String in SAMLUtils, I fixed it in CXF master here: https://github.com/apache/cxf/commit/1e90f53f720b76c2dbac910e58ef0b291f98c032 Colm. On Tue, Mar 22, 2022 at 12:48 PM Jim Ma wrote: > > Hi Colm, > > Please checkout my working branch : >

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-22 Thread Jim Ma
Hi Colm, Please checkout my working branch : https://github.com/jimma/cxf/tree/wss4j-30-jakarta Build all cxf artifacts first with: mvn clean install -Pfastinstall then go to systests/ws-security, run these tests and you'll get these test failures. Please let me know if you have other issues when

Re: Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-22 Thread Colm O hEigeartaigh
Hi Jim, Which branch are you testing this on in CXF? Colm. On Mon, Mar 21, 2022 at 7:26 AM Jim Ma wrote: > > Hi Colm, > After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version) in CXF, > I got the following ws-security systests failures. > Could you please help look at if there is

Systest failures with wss4j-3.0.0-SNAPSHOT

2022-03-21 Thread Jim Ma
Hi Colm, After I upgraded wss4j version to 3.0.0-SNAPSHOT(jakarta version) in CXF, I got the following ws-security systests failures. Could you please help look at if there is still something we need to fix in wss4j ? Or we need to fix it in CXF ? Thanks, Jim