Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-20 Thread Sergey Beryozkin
On 20/11/12 09:42, Freeman Fang wrote: Thanks Sergey. Dan pointed out we actually needn't CR/LF here at all, please see my last comment in CXF-4482. thanks, I've just seen that too...I guess I'd then only consider the addition property if we had a case of the consumer failing to read withou

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-20 Thread Freeman Fang
Thanks Sergey. Dan pointed out we actually needn't CR/LF here at all, please see my last comment in CXF-4482. - Freeman(Yue) Fang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://fusesource.com | http://www.redhat.com/ Twitter: freemanfang Blog: http://freemanfang.blogsp

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-20 Thread Sergey Beryozkin
Hi On 20/11/12 02:40, Freeman Fang wrote: Hi Dan, But if on unix/linux platform, if we have "\r\n", it interpret as two new line, which can cause some service providers can't handle the request, I think what we want should be a "new line" here, so use system property line.separator should be O

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-19 Thread Daniel Kulp
On Nov 19, 2012, at 10:02 PM, Freeman Fang wrote: > Hi Dan, > > Did another commit using org.apache.cxf.common.util.SystemPropertyAction > instead of sun.security.action.GetPropertyAction. > > And IMO different platform interpret CRLF with different way, on windows, it > need "\r\n", and on

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-19 Thread Freeman Fang
Hi Dan, Did another commit using org.apache.cxf.common.util.SystemPropertyAction instead of sun.security.action.GetPropertyAction. And IMO different platform interpret CRLF with different way, on windows, it need "\r\n", and on unix/linux, it just need "\n", and system property line.separator

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-19 Thread Freeman Fang
Hi Dan, But if on unix/linux platform, if we have "\r\n", it interpret as two new line, which can cause some service providers can't handle the request, I think what we want should be a "new line" here, so use system property line.separator should be OK, please see the initial description from

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-19 Thread Daniel Kulp
Actually, more importantly, this makes the payload different depending on if its from Unix or Windows. According to the mid spec: http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html (section 7.2.1) it should always be a CRLF, so the code would be updated to always use that for the attachm

Re: svn commit: r1411506 - /cxf/trunk/api/src/main/java/org/apache/cxf/attachment/AttachmentSerializer.java

2012-11-19 Thread Daniel Kulp
Umm… don't use anything from sun.* packages. You can use org.apache.cxf.common.util.SystemPropertyAction if that works. Dan On Nov 19, 2012, at 8:56 PM, ff...@apache.org wrote: > Author: ffang > Date: Tue Nov 20 01:56:17 2012 > New Revision: 1411506 > > URL: http://svn.apache.org/viewv