Re: Issue with separatorSuppressionPolicy and empty elements in IBM4690-TLOG scheams

2017-11-27 Thread Mike Beckerle
Well the separator suppression code has not had a lot of scrutiny. I wrote this a *long time* ago, and honestly have not revisited it since. I assume you figured out that separatorSuppressionPolicy replaced the separatorPolicy property. This happened after IBM released it's first DFDL product, a

Issue with separatorSuppressionPolicy and empty elements in IBM4690-TLOG scheams

2017-11-27 Thread Joshua Adams
Hey Mike, Wanted to get your opinion on the issue I've been running into with IBM4690-TLOG schemas. I talked with Steve for a while trying to figure out what was going on and we came to the opinion that there is either an issue with the TLOG schemas, or (perhaps more likely) there is an error

Re: LWAP project needs a fix to v2.0.0

2017-11-27 Thread John D. Ament
You need the SGA to do a relicense, yes. However, there is nothing blocking you from doing a release here at Apache, with the code licensed under BSD. We just have to make sure the original licenses are intact, and watch for any modifications to the files under the IBM SGA. If NCSA is days away f

Re: LWAP project needs a fix to v2.0.0

2017-11-27 Thread Dave Fisher
Hi (1) It is recommended that you release using old infrastructure. You should add the DISCLAIMER. You should say that it is a maintenance release as the project transitions to the ASF. (2) If you need any help with the IBM SGA then let the mentors know. If John agrees then this type of discus

Re: Fw: LWAP project needs a fix to v2.0.0

2017-11-27 Thread Mike Beckerle
Ok, so I'd like to put the changes on the support branch, also on master branch, but then not release it. Should we consider pushing the support branch to NCSA servers - as branch 2.0.1, and then do a release from that infrastructure? This is a very small set of changes, but a release is much

[GitHub] incubator-daffodil issue #6: Eliminate spurious SDE when using lengthKind pa...

2017-11-27 Thread stevedlawrence
Github user stevedlawrence commented on the issue: https://github.com/apache/incubator-daffodil/pull/6 +1 ---

[GitHub] incubator-daffodil pull request #6: Eliminate spurious SDE when using length...

2017-11-27 Thread stevedlawrence
Github user stevedlawrence commented on a diff in the pull request: https://github.com/apache/incubator-daffodil/pull/6#discussion_r153242194 --- Diff: daffodil-core/src/test/scala-new/edu/illinois/ncsa/daffodil/dsom/TestIsScannable.scala --- @@ -0,0 +1,143 @@ +/* Copyright (c

[GitHub] incubator-daffodil pull request #6: Eliminate spurious SDE when using length...

2017-11-27 Thread mbeckerle
Github user mbeckerle commented on a diff in the pull request: https://github.com/apache/incubator-daffodil/pull/6#discussion_r153241928 --- Diff: daffodil-core/src/test/scala-new/edu/illinois/ncsa/daffodil/dsom/TestIsScannable.scala --- @@ -0,0 +1,143 @@ +/* Copyright (c) 201

[GitHub] incubator-daffodil pull request #6: Eliminate spurious SDE when using length...

2017-11-27 Thread stevedlawrence
Github user stevedlawrence commented on a diff in the pull request: https://github.com/apache/incubator-daffodil/pull/6#discussion_r153196922 --- Diff: daffodil-core/src/test/scala-new/edu/illinois/ncsa/daffodil/dsom/TestIsScannable.scala --- @@ -0,0 +1,143 @@ +/* Copyright (c

[GitHub] incubator-daffodil pull request #6: Eliminate spurious SDE when using length...

2017-11-27 Thread stevedlawrence
Github user stevedlawrence commented on a diff in the pull request: https://github.com/apache/incubator-daffodil/pull/6#discussion_r153195913 --- Diff: daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/dsom/TermEncodingMixin.scala --- @@ -177,6 +177,7 @@ trait TermEncodingMi

[GitHub] incubator-daffodil issue #6: Eliminate spurious SDE when using lengthKind pa...

2017-11-27 Thread stevedlawrence
Github user stevedlawrence commented on the issue: https://github.com/apache/incubator-daffodil/pull/6 It would be nice if there was a commit message that explained the changes, and what was wrong with the previous code. It makes sense after looking at it, but I had to look up what No

Re: Fw: LWAP project needs a fix to v2.0.0

2017-11-27 Thread Steve Lawrence
There are a couple of potential issues with this: 1) The sbt build infrastructure currently depends on branches and tags named a certain way. The new branch/tag guidelines break that. Pull request #3 [1] fixes this and adds "Apache" and "incubating" where appropriate. This needs an additional +1 b