[
https://issues.apache.org/jira/browse/DAFFODIL-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549418#comment-16549418
]
Michael Beckerle edited comment on DAFFODIL-1948 at 7/20/18 4:24 PM:
---
On further study of the DFDL spec, section 14.2.2.2 makes it clear that
trailingEmptyStrict tolerates non-trailing empty elements, and just absorbs the
separators for them, so the behavior is not as I described.
So perhaps the right behavior by default is "anyEmpty". I still need to confirm
th
[
https://issues.apache.org/jira/browse/DAFFODIL-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Beckerle updated DAFFODIL-1888:
---
Summary: byte swap layer capability - was: byteOrder bigEndian with
bitOrder least
[
https://issues.apache.org/jira/browse/DAFFODIL-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550893#comment-16550893
]
Michael Beckerle commented on DAFFODIL-1888:
So this change resolved Marsh
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r20408
##
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
##
@@
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204083795
##
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequenceParsers.scala
##
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204083507
##
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/NilEmptyCombinatorParsers.scala
#
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204082615
##
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/DelimiterParsers.scala
##
@@ -15
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204081776
##
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala
##
@@ -618,8 +622,9 @@
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204080825
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ComplexTypeCombinator.scala
##
@@ -0
[
https://issues.apache.org/jira/browse/DAFFODIL-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550874#comment-16550874
]
James L Welch commented on DAFFODIL-1969:
-
The temporary workaround made a com
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204077054
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala
##
@@ -0,0 +1
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204075439
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/SequenceGrammarMixin.scala
##
@@ -17,36 +17,113
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204069230
##
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##
@@ -359,6 +360,25 @@ trait Term
de
mbeckerle commented on a change in pull request #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r204055199
##
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##
@@ -359,6 +360,25 @@ trait Term
de
mbeckerle commented on issue #74: Daffodil trailing sep
URL: https://github.com/apache/incubator-daffodil/pull/74#issuecomment-406607804
Closing - will incorporate changes, but this PR was really a very
preliminary code review, and the code has evolved in structure substantially
since this
mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use
of the same character for escapeBlockEnd and escapeEscapeCharacter
URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r204049433
##
File path:
daffodil-runtime1/src/main/scala/org/apach
mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use
of the same character for escapeBlockEnd and escapeEscapeCharacter
URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r204049977
##
File path:
daffodil-runtime1/src/main/scala/org/apach
[
https://issues.apache.org/jira/browse/DAFFODIL-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549615#comment-16549615
]
Michael Beckerle edited comment on DAFFODIL-1948 at 7/20/18 12:11 PM:
--
[
https://issues.apache.org/jira/browse/DAFFODIL-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550717#comment-16550717
]
Michael Beckerle commented on DAFFODIL-1948:
If you change only dfdl:occur
I have been at this problem of separators and separator suppression behavior in
Daffodil for around 3 full weeks of my time now, so I wanted to explain the
status of the work.
The prior code-review pull-request will not be updated. I will incorporate the
suggestions from it that are still rele
21 matches
Mail list logo
