[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #207: Added support for enumerations and TypeValueCalc

2019-04-10 Thread GitBox
bsloane1650 opened a new pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207 Not quite done yet. I still want to improve the test coverage. But, given the size, I wanted to start the review process as well now that

[jira] [Created] (DAFFODIL-2107) Implement Enum Support

2019-04-10 Thread Brandon Sloane (JIRA)
Brandon Sloane created DAFFODIL-2107: Summary: Implement Enum Support Key: DAFFODIL-2107 URL: https://issues.apache.org/jira/browse/DAFFODIL-2107 Project: Daffodil Issue Type: Improvement

[jira] [Commented] (DAFFODIL-498) Add automated build for Windows

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814779#comment-16814779 ] Steve Lawrence commented on DAFFODIL-498: - After looking around for good window

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #206: Decrease time needed for continue integration builds

2019-04-10 Thread GitBox
stevedlawrence commented on a change in pull request #206: Decrease time needed for continue integration builds URL: https://github.com/apache/incubator-daffodil/pull/206#discussion_r274092154 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/executing/TestCLIexecuting.sc

[GitHub] [incubator-daffodil] stevedlawrence commented on issue #206: Decrease time needed for continue integration builds

2019-04-10 Thread GitBox
stevedlawrence commented on issue #206: Decrease time needed for continue integration builds URL: https://github.com/apache/incubator-daffodil/pull/206#issuecomment-481800429 For reference, here is the Azure build I set up: https://dev.azure.com/stevedlawrence/incubator-daffodil.gi

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #206: Decrease time needed for continue integration builds

2019-04-10 Thread GitBox
stevedlawrence commented on a change in pull request #206: Decrease time needed for continue integration builds URL: https://github.com/apache/incubator-daffodil/pull/206#discussion_r274085714 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/executing/TestCLIexecuting.sc

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #206: Decrease time needed for continue integration builds

2019-04-10 Thread GitBox
mbeckerle commented on a change in pull request #206: Decrease time needed for continue integration builds URL: https://github.com/apache/incubator-daffodil/pull/206#discussion_r274084357 ## File path: daffodil-cli/src/it/scala/org/apache/daffodil/executing/TestCLIexecuting.scala

Re: Understanding outputValueCalc elements

2019-04-10 Thread Sloane, Brandon
I think I see the issue. OVCStartEndStrategy.unparseBegin calls: val eventMaybe = state.inspectMaybe as part of determining if it needs to consume any events (since non-hidden OVC elements are optional) The issue is that the logic in inspect is a bit wonky. In particular, Cursor.scala has

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #206: Decrease time needed for continue integration builds

2019-04-10 Thread GitBox
stevedlawrence opened a new pull request #206: Decrease time needed for continue integration builds URL: https://github.com/apache/incubator-daffodil/pull/206 - In the TravisCI configuration, we only enabled coverage when running tests. However, coverage actually needs to be enabled du

[jira] [Assigned] (DAFFODIL-2105) TravisCI builds take too long

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence reassigned DAFFODIL-2105: Assignee: Steve Lawrence > TravisCI builds take too long >

Re: Understanding outputValueCalc elements

2019-04-10 Thread Steve Lawrence
I'm not sure how the OVC element could appear after where it is supposed to appear, but we do actually allow OVC elements to be missing from the infoset. Whether or not this is correct might be up for debate. The logic for creating OVC elements that are missing is in the OVCStartEndStrategy trait

Understanding outputValueCalc elements

2019-04-10 Thread Sloane, Brandon
I am a bit confused with the behaviour of one of my test cases. I have the schema: With the test case: 0E http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814436#comment-16814436 ] Michael Beckerle commented on DAFFODIL-1559: PUA isn't necessary for CR, b

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814415#comment-16814415 ] Steve Lawrence commented on DAFFODIL-1559: -- Nix the above comment. If I use x

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814411#comment-16814411 ] Steve Lawrence commented on DAFFODIL-1559: -- And actually, maybe &#...; are al

[jira] [Comment Edited] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814406#comment-16814406 ] Steve Lawrence edited comment on DAFFODIL-1559 at 4/10/19 12:23 PM:

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814406#comment-16814406 ] Steve Lawrence commented on DAFFODIL-1559: -- Rather than using the PUA, it mig

Re: Exposing latent SDEs

2019-04-10 Thread Beckerle, Mike
To achieve Seq[=> T] You will need a call-by-name constructor. Traditionally these are named: class Delay[T](byNameValue: => T) { lazy val value = byNameValue def get = value } So you need to create a Seq[Delay[T]] not a Seq[=> T] To force the evaluation you just call get or value on the

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814385#comment-16814385 ] Michael Beckerle commented on DAFFODIL-1559: Changed this to a bug.  Incre

[jira] [Updated] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle updated DAFFODIL-1559: --- Priority: Major (was: Minor) > Add option to disable CRLF to LF XML canonicalizat

[jira] [Updated] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle updated DAFFODIL-1559: --- Issue Type: Bug (was: New Feature) > Add option to disable CRLF to LF XML canonic

[jira] [Commented] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814382#comment-16814382 ] Michael Beckerle commented on DAFFODIL-1559: Freestanding CR also needs to

[jira] [Updated] (DAFFODIL-1559) Add option to disable CRLF to LF XML canonicalization

2019-04-10 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle updated DAFFODIL-1559: --- Labels: beginner (was: ) > Add option to disable CRLF to LF XML canonicalization