[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277512873 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277514352 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ## @@ -0,0 +

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511435 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511710 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277512516 ## File path: daffodil-test/src/test/resources/org/apache/daffodil/layers/midBitsToEnd.tdml ## @@ -0,0 +

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277513113 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala #

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
mbeckerle commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r277511326 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/GZipTransformer.scala ## @@ -2

[jira] [Commented] (DAFFODIL-2110) Cannot change bitorder mid schema

2019-04-22 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823656#comment-16823656 ] Michael Beckerle commented on DAFFODIL-2110: I think this ticket is mistak

[jira] [Assigned] (DAFFODIL-2110) Cannot change bitorder mid schema

2019-04-22 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle reassigned DAFFODIL-2110: -- Assignee: (was: Michael Beckerle) > Cannot change bitorder mid schema >

[jira] [Resolved] (DAFFODIL-2110) Cannot change bitorder mid schema

2019-04-22 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle resolved DAFFODIL-2110. Resolution: Won't Fix > Cannot change bitorder mid schema >

[jira] [Assigned] (DAFFODIL-2110) Cannot change bitorder mid schema

2019-04-22 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Beckerle reassigned DAFFODIL-2110: -- Assignee: Michael Beckerle (was: Brandon Sloane) > Cannot change bitorder

Re: Understanding bitOrder=leastSignificantFirst

2019-04-22 Thread Beckerle, Mike
Your test cant work. Bit order doesnt work that way. Unless a partial byte is involved bit order does nothing. The values of whole bytes don't change. There is a bit order tutorial in the daffodil tutorials module. Suggest you start there. If you view the bitOrder tdml.xml file with firefox it

Understanding bitOrder=leastSignificantFirst

2019-04-22 Thread Sloane, Brandon
I am trying to work through a bug surrounding changing the bitOrder mid schema and am having trouble figuring out how Daffodil handles bitOrder in general. I see that in InputSourceData, we have code to mask for the correct bits and shift out the gaps, but I do not see where we actually invert

[jira] [Created] (DAFFODIL-2110) Cannot change bitorder mid schema

2019-04-22 Thread Brandon Sloane (JIRA)
Brandon Sloane created DAFFODIL-2110: Summary: Cannot change bitorder mid schema Key: DAFFODIL-2110 URL: https://issues.apache.org/jira/browse/DAFFODIL-2110 Project: Daffodil Issue Type:

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #201: Fix bug in handling parse errors

2019-04-22 Thread GitBox
bsloane1650 commented on a change in pull request #201: Fix bug in handling parse errors URL: https://github.com/apache/incubator-daffodil/pull/201#discussion_r277408855 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessingError.scala ##

[GitHub] [incubator-daffodil] jadams-tresys opened a new pull request #211: Escape all delimiters when unparsing

2019-04-22 Thread GitBox
jadams-tresys opened a new pull request #211: Escape all delimiters when unparsing URL: https://github.com/apache/incubator-daffodil/pull/211 Previously we were only escaping the first delimiter in the list of delimiters specified by initiator, terminator and separator. Now we will es

[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #210: Add midBitsToEnd layer transform

2019-04-22 Thread GitBox
bsloane1650 opened a new pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210 Add new layer transform that can move a single contiguous block of bits from a layer's content area to the end of the layer's content area. DAF

[jira] [Created] (DAFFODIL-2109) New transform layer to support non-standard padding

2019-04-22 Thread Brandon Sloane (JIRA)
Brandon Sloane created DAFFODIL-2109: Summary: New transform layer to support non-standard padding Key: DAFFODIL-2109 URL: https://issues.apache.org/jira/browse/DAFFODIL-2109 Project: Daffodil