[GitHub] [incubator-daffodil] bsloane1650 opened a new pull request #249: Emit SDE when a type calculator attempts to use an undefined type.

bsloane1650 opened a new pull request #249: Emit SDE when a type calculator attempts to use an undefined type. URL: https://github.com/apache/incubator-daffodil/pull/249 This lays down the infrastructure which allows the DPath interperator to lookup type calculators at compile time, w

Re: Missing typecalc functions

I think we also saw this map serialization problem in the choice map stuff, i.e., NextElementResolver is I think one of the primary classes. One of the kinds of resolvers creates a map, and there is some unusual unintuitive code there for serializing it. From: S

Re: Missing typecalc functions

Weird. This seems to fix it if I do it in the DPathCompileInfo object itself; but does not work if I do it where I first build the map. I would say this is some weird type system issue, but I can even put a type annotation on the serialized field and have it still work. It works, so I can't r

Re: Missing typecalc functions

I believe we had issues related to serializing maps with direct dispatch choices. I don't recall why or how we found the solution, but the solution was to map it with the identity. We do the following in ChoiceCombinator.scala: val serializableMap: Map[String, (Parser, Boolean)] = dispatchBran

Re: Missing typecalc functions

Related to below "other issues", I appear to be having an issue wit serializing typeCalcMap now: java.lang.ClassCastException: cannot assign instance of scala.collection.immutable.HashMap$SerializationProxy to field org.apache.daffodil.dsom.DPathCompileInfo.typeCalcMap of type scala.collectio

[jira] [Reopened] (DAFFODIL-2148) No compile time error when using nonexistent TypeCalc function

[ https://issues.apache.org/jira/browse/DAFFODIL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Sloane reopened DAFFODIL-2148: -- The difficulty here is also a blocker for DAFFODIL-2165 , so I'm going to take another

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #248: Add debugger infosetParents config option and update trace mode

stevedlawrence opened a new pull request #248: Add debugger infosetParents config option and update trace mode URL: https://github.com/apache/incubator-daffodil/pull/248 This new config option determines how many parent elements to include when running the "info infoset" debugger command

Re: Missing typecalc functions

I picked up where I left off on my previous attempt. Instead of trying to pass the full runtime state through (which I believe runs into the issue Mike is talking about), I am restricting what I pass through to just the typeCalcMap. This is where I abandoned the endevour last time. It appears

Re: Missing typecalc functions

I'm hard at work on the whole "backpointers" problem and this could help decouple the runtime data objects. I think there is an invariant we're not taking advantage of. Everything that goes onto a runtime data object (both the DPathCompileInfo object, and the RuntimeData objects) should be ava

Re: Missing typecalc functions

I think I looked into that possibility previously. During the initial design phases, I was concerned about the implication for other implementations (since, this is a pretty substantial departure from how the rest of the type system works). More recently, I discovered that we were an implemen

[jira] [Assigned] (DAFFODIL-1931) Debug/trace - prints spurious error message about ".."

[ https://issues.apache.org/jira/browse/DAFFODIL-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence reassigned DAFFODIL-1931: Assignee: Steve Lawrence > Debug/trace - prints spurious error message about ".

Re: [DISCUSS] Release Daffodil 2.4.0

Seems reasonable to me. I just put DAFFODIL-2163 in review. I'll take a look at the first one in your list. - Steve On 6/25/19 8:50 AM, Beckerle, Mike wrote: > I concur we need to do a release. > > > I prioritized two bugs as blocking/critical a while back since I think > they're quite importa

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #247: Fix unused properties related to implied choice sequences

stevedlawrence commented on a change in pull request #247: Fix unused properties related to implied choice sequences URL: https://github.com/apache/incubator-daffodil/pull/247#discussion_r297275560 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.sc

Re: Missing typecalc functions

I've always thought it seemed odd that we had typed functions. Instead of adding more functions, it seems like it might be worth rethinking how the functions work. For example, instead of taking a string, maybe they could take a QName, and the return type is going to be the type of the primitive ty

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #247: Fix unused properties related to implied choice sequences

mbeckerle commented on a change in pull request #247: Fix unused properties related to implied choice sequences URL: https://github.com/apache/incubator-daffodil/pull/247#discussion_r297272063 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #247: Fix unused properties related to implied choice sequences

stevedlawrence opened a new pull request #247: Fix unused properties related to implied choice sequences URL: https://github.com/apache/incubator-daffodil/pull/247 When a ChoiceBranchImpliedSequence was created, because groupMembers was not overridden, it would actually create a complete

Re: Missing typecalc functions

Where Double is needed, one often finds that Decimal is needed. Anywhere that base-10 rounding semantics is required one tends to need Decimal. For date/time I know of one exception example that came up in the DFDL workgroup. They had time expressed in units of measure not supported by t

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding

mbeckerle commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding URL: https://github.com/apache/incubator-daffodil/pull/245#discussion_r297259993 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/X_DFDL_MIL_STD.sc

Missing typecalc functions

The typeCalc functions are all specialized by their return type; and currently support only Integer and String. It appears that there is a need to at least add Double to this list. (My use-case here is VMF/Link-16 where, for example, "degrees" is specified in units of 360/2^n making an Int->Doub

[jira] [Created] (DAFFODIL-2165) Add *Double functions to the typeCalc family of functions

Brandon Sloane created DAFFODIL-2165: Summary: Add *Double functions to the typeCalc family of functions Key: DAFFODIL-2165 URL: https://issues.apache.org/jira/browse/DAFFODIL-2165 Project: Daffodi

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding

bsloane1650 commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding URL: https://github.com/apache/incubator-daffodil/pull/245#discussion_r297238403 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/X_DFDL_MIL_STD.

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding

bsloane1650 commented on a change in pull request #245: Added X-DFDL-5-BIT-DFI-1661-DUI-001 char encoding URL: https://github.com/apache/incubator-daffodil/pull/245#discussion_r297210463 ## File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/X_DFDL_MIL_STD.

Re: [DISCUSS] Release Daffodil 2.4.0

I concur we need to do a release. I prioritized two bugs as blocking/critical a while back since I think they're quite important. https://issues.apache.org/jira/browse/DAFFODIL-1931 https://issues.apache.org/jira/browse/DAFFODIL-1477

[DISCUSS] Release Daffodil 2.4.0

We've added a lot of good features and bug fixes to Daffodil since the 2.3.0 release, and it's about that time where we need to start thinking about getting the next release out. One bug I would like to get resolved is DAFFODIL-2163, which I think I can track down this week. Are there any other is