Re: Validator SPI proposal

2020-10-01 Thread Beckerle, Mike
FYI: John Wass - I am also going to surf your code a bit so may have more comments. I've fetched from your ctc-oss repositories. One thing the UDF code did work through is how to define a SPI-based feature for Daffodil and also include test-specific instances of it and test them, all in the daf

Re: Validator SPI proposal

2020-10-01 Thread Beckerle, Mike
A few thoughts on top of John Interrante's review. The validator code/clases being found via SPI seems good. Sharing code/library with the existing usage for UDFs would be nice if it works out. The validator code reads in various "specs". For XML Schema validation with xerces, this is the XML S

Re: Daffodil-1300

2020-10-01 Thread Beckerle, Mike
I think the DFDLTestSuite constructor can't stay deprecated. We still need to construct them. It can become package private I think, so not usable outside the package. I think the scala syntax for that is: class Foo private[pkgName] (arg1: Type1, arg2: Type2) { ... } The deprecation was just

Daffodil-1300

2020-10-01 Thread Carlson, Ian
Regarding DAFFODIL-1300, I’m hunting down usage of “new DFDLTestSuite” and replacing them with usage of the “Runner” object. In order to help identify where the DFDLTestSuite was being invoked, I un-commented: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala line 198 @