Re: flakey windows CI build? Or real issue?

2021-04-29 Thread Beckerle, Mike
Wow, they even coined a term for this macro stuff... "check-enabled-idiom". It says Apache License 2.0 in the License file. From: Steve Lawrence Sent: Thursday, April 29, 2021 3:51 PM To: dev@daffodil.apache.org Subject: Re: flakey windows CI build? Or real issue

Re: need 2nd reviewer on PR

2021-04-29 Thread Adams, Joshua
Sorry for the delay, I'll take a look at this tonight when I get home if it still needs a second review. Josh On Apr 29, 2021 12:42 PM, "Beckerle, Mike" wrote: https://github.com/apache/daffodil/pull/539 Needs a second reviewer. I added some "Highlights" comments to the files diffs to help y

Re: flakey windows CI build? Or real issue?

2021-04-29 Thread Steve Lawrence
Good point. It looks like scala-logging has that macro stuff, and is a wrapper for SLF4J so I would assume could be easily used by Java applications: https://github.com/lightbend/scala-logging I haven't looked at license/dependency of that, but something like that might ork. On 4/29/21 3:31 PM,

Re: flakey windows CI build? Or real issue?

2021-04-29 Thread Beckerle, Mike
I have no problem using someone else's logging infrastructure. The only sort-of-requirement is I've always hated the overhead of logging because to create a good log message you end up doing a bunch of work and then you pass that to the logger which says "not at the log level where that is need

need 2nd reviewer on PR

2021-04-29 Thread Beckerle, Mike
https://github.com/apache/daffodil/pull/539 Needs a second reviewer. I added some "Highlights" comments to the files diffs to help you surf the deltas more effectively. This fixes an issue a user was having doing streaming reads of messages. Mike Beckerle | Principal Engineer [cid:2f6f0715-6c