RE: How to add warnings that are not lost due to backtracking

2020-12-18 Thread Carlson, Ian
I’m still new at this – but I’ve found a great way to learn is to invite people to tell me I’m wrong, so here’s my two cents. SDE in particular is generally used to tell the parser that something has gone wrong. This invites the parser to either back up to the most recent point of uncertainty a

RE: 2399 - Changing error code for missing separators

2020-10-26 Thread Carlson, Ian
c is properly implemented is quite difficult and will require development of an extensive collection of tests that cover all these various combinations of features of DFDL. I think right now, the important thing is no regression on any known existing DFDL schemas. __

2399 - Changing error code for missing separators

2020-10-21 Thread Carlson, Ian
All, I’ve done a great deal of digging to find the cause of the bug DAFFODIL-2399. It appears to come down to SeparatedSequenceChildParseResultHelper.scala line 282. In this case, we have found an out of scope delimiter %NL; before finding any elements, and as a result we abort parsing the sequ

RE: Daffodil-1300

2020-10-07 Thread Carlson, Ian
ably we can just depend on Scala's ability to pass arguments by specifying the argument names explicitly and getting defaults for the rest. I think calls to Runner already do this in many cases. From: Carlson, Ian Sent: Thursday, October 1, 2020 4:

Daffodil-1300

2020-10-01 Thread Carlson, Ian
Regarding DAFFODIL-1300, I’m hunting down usage of “new DFDLTestSuite” and replacing them with usage of the “Runner” object. In order to help identify where the DFDLTestSuite was being invoked, I un-commented: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala line 198 @

RE: Removing Length Check for Complex Types

2020-09-23 Thread Carlson, Ian
. If a test is specifically testing not enough data for complex types, the test should be fixed so that those child elements succeed. There may be other tweaks needed to tests depending on what tests are trying to accomplish. On 9/22/20 7:12 PM, Carlson, Ian wrote: > While pursuing DAFFODIL-2395 >

Removing Length Check for Complex Types

2020-09-22 Thread Carlson, Ian
While pursuing DAFFODIL-2395, I experimented with SpecifiedLengthParsers.scala, specifically the check isDefinedForLength. I added logic to only do this check for non-complex types so we wouldn’t look ahead across types that might be so large

Contributor Access

2020-09-14 Thread Carlson, Ian
I'm requesting contributor access to the DFDL repo and JIRA boards. Git username: IanCarlsonOwl Thank you, Ian