[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289567468 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Facets.scala ## @@ -22,7 +22,7

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289567820 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RestrictionUnion.scala ## @@ -

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289568013 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -6

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289568170 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ## @@ -402,10

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289568246 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala ## @@ -61,12

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289568662 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala ## @@ -296,6

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-05-31 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289569122 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementCombinator1.sca

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289826176 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -6

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289833087 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ## @@ -250,8

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289833328 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala ## @@ -250,8

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289834036 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -5

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289834437 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -5

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289838166 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -1

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289838489 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -1

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289986059 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala ## @@ -315,

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289987387 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala ## @@ -62,22 +

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289990613 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala ##

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types

2019-06-03 Thread GitBox
mbeckerle commented on a change in pull request #223: Daffodil 1444 schema comp simple types URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289995419 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala ## @@ -315,