[PR] Clean up codegen to avoid exceptions and allow that processing path [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin opened a new pull request, #23: URL: https://github.com/apache/datasketches-spark/pull/23 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin merged PR #21: URL: https://github.com/apache/datasketches-spark/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@dataske

Re: [PR] fix issue 136 [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov merged PR #138: URL: https://github.com/apache/datasketches-bigquery/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972576833 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(child: Expr

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972576235 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(child: Expr

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972576833 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(child: Expr

Re: [PR] Add a partial example of using the library with airflow+dataproc [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin merged PR #22: URL: https://github.com/apache/datasketches-spark/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@dataske

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972572988 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(c

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972571777 ## src/main/scala/org/apache/spark/sql/datasketches/theta/aggregate/ThetaSketchAggUnion.scala: ## @@ -48,65 +54,81 @@ import org.apache.spark.sql.types

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972572028 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(c

[PR] fix issue 136 [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov opened a new pull request, #138: URL: https://github.com/apache/datasketches-bigquery/pull/138 cherry-picked from main in preparation for patch release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix issue 136 [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov merged PR #137: URL: https://github.com/apache/datasketches-bigquery/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

Re: [I] Failure in kll_sketch_float_build_k() [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on issue #136: URL: https://github.com/apache/datasketches-bigquery/issues/136#issuecomment-2685894000 this should fix the issue, but I am not sure how to test: #137 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] fix issue 136 [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov opened a new pull request, #137: URL: https://github.com/apache/datasketches-bigquery/pull/137 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Failure in kll_sketch_float_build_k() [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on issue #136: URL: https://github.com/apache/datasketches-bigquery/issues/136#issuecomment-2685837525 And again I could not reproduce this in my environment. The above query runs fine for me. I tried to increase the number in GENERATE, but it fails with "GENERA

Re: [I] Failure in kll_sketch_float_build_k() [datasketches-bigquery]

2025-02-26 Thread via GitHub
AlexanderSaydakov commented on issue #136: URL: https://github.com/apache/datasketches-bigquery/issues/136#issuecomment-2685800970 Right. Again this code path after the transition from deserialize back to aggregate, which does not happen often. It is not exercised in small tests. I belie

[I] Failure in kll_sketch_float_build_k() [datasketches-bigquery]

2025-02-26 Thread via GitHub
nikunjbhartia opened a new issue, #136: URL: https://github.com/apache/datasketches-bigquery/issues/136 Query: ``` SELECT group_key, count(*) AS total_count, bqutil.datasketches.kll_sketch_float_build_k(x, 250) AS kll_sketch FROM ( SELECT CONCAT("group_key

Re: [PR] Theta params [datasketches-spark]

2025-02-26 Thread via GitHub
jmalkin commented on code in PR #21: URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1971123772 ## src/main/scala/org/apache/spark/sql/datasketches/theta/expressions/ThetaExpressions.scala: ## @@ -71,3 +73,60 @@ case class ThetaSketchGetEstimate(child: Expr