An issue was reported a few days ago: https://github.com/apache/datasketches-cpp/issues/227 We have a fix, and I would like to include the fix into this release. Let us cancel this vote and open a new one after cherry-picking this fix into the 3.1.x branch. I will prepare the rc2. I appreciate all the votes in support of rc1. Please excuse this delay and vote on rc2. Please consider this vote cancelled. Thank you.
On Tue, Jul 6, 2021 at 10:20 AM Jon Malkin <jon.mal...@gmail.com> wrote: > +1 > > - Checked signature and shasum > - Successful build > - Spurious failure in kll_test; ok on re-run > - tox ran after linking in pybind11 > > But we also have an open issue. Not sure if we should determine the cause > of that first? > > jon > > On Mon, Jul 5, 2021 at 9:16 AM David Cromberge < > david.crombe...@permutive.com> wrote: > >> Hi, >> >> +1 from me. >> >> I have successfully run through all the instructions in the Build & Test >> guide on the 3.1.0-rc1 candidate. >> >> Thanks, >> David >> >> On 1 Jul 2021, at 22:53, Alexander Saydakov < >> sayda...@verizonmedia.com.INVALID> wrote: >> >> Hello Apache DataSketches PMC and Community, >> >> This is a call for vote to release Apache DataSketches-cpp candidate >> version: 3.1.0-rc1 >> >> Changes since the last release 3.0.0: >> - Kolmogorov-Smirnov test for KLL sketch >> - custom seed support in Theta Jaccard similarity >> - Theta union bug fix >> - added get_max_serialized_size_bytes method for KLL and CPC sketches >> - added wrapped_compact_theta_sketch to avoid some cost of >> deserialization >> - massive code cleanup to avoid compiler warnings >> - iterator fix in KLL sketch >> - iterator fix in REQ sketch >> - exception safety fix in theta_update_sketch_base >> - misaligned access fix in MurmurHash3 >> >> Source repository: >> - https://github.com/apache/datasketches-cpp >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp-26source-3Dgmail-2Dimap-26ust-3D1625781259000000-26usg-3DAOvVaw22pPo8txxkKerC3BJkEIvC&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=Y9kz7f6krL8hRtLVUvAngbiNYqNQVRHoSxDSlb2A2Fg&s=Nq08l-pyS0gb7E7a0-SkCK7znNe7jd8LkeTEHCBWRl4&e=> >> >> Git Tag for this release: >> - https://github.com/apache/datasketches-cpp/tree/3.1.0-rc1 >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp_tree_3.1.0-2Drc1-26source-3Dgmail-2Dimap-26ust-3D1625781259000000-26usg-3DAOvVaw3CB2G08kxJaTLmRHx4csiY&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=Y9kz7f6krL8hRtLVUvAngbiNYqNQVRHoSxDSlb2A2Fg&s=EtRFszjae2ibMPcHYQmTFUENvQV6adzj24QIpzqpUa4&e=> >> on >> branch 3.1.x >> >> Git HashId for this release starts with: 45885c0 >> >> The Release Candidate / Zip Repository: >> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.1.0-rc1/ >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__dist.apache.org_repos_dist_dev_datasketches_cpp_3.1.0-2Drc1_-26source-3Dgmail-2Dimap-26ust-3D1625781259000000-26usg-3DAOvVaw0B-2DZ66zNCl45P2FvvgkyQp&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=Y9kz7f6krL8hRtLVUvAngbiNYqNQVRHoSxDSlb2A2Fg&s=WEX--uYTSfQM_UbRAMeO_VLoSZFyBiMJE86v-20JxQc&e=> >> >> The public signing key can be found in the KEYS file: >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__dist.apache.org_repos_dist_dev_datasketches_KEYS-26source-3Dgmail-2Dimap-26ust-3D1625781259000000-26usg-3DAOvVaw0Kp8CBZkqRlAdYdhujJ6wf&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=Y9kz7f6krL8hRtLVUvAngbiNYqNQVRHoSxDSlb2A2Fg&s=TN2tQKieZp96kqiG9neQfEwnaVoKvERZvn_U6hXHPBE&e=> >> >> >> The artifacts have been signed with key: >> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < >> al...@apache.org> >> >> Build & Test Guide: >> - https://github.com/apache/datasketches-cpp/blob/3.1.0-rc1/README.md >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.google.com_url-3Fq-3Dhttps-3A__github.com_apache_datasketches-2Dcpp_blob_3.1.0-2Drc1_README.md-26source-3Dgmail-2Dimap-26ust-3D1625781259000000-26usg-3DAOvVaw1gOD-5F8a0ltMxZOeCsfM0F4&d=DwMFaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=0TpvE_u2hS1ubQhK3gLhy94YgZm2k_r8JHJnqgjOXx4&m=Y9kz7f6krL8hRtLVUvAngbiNYqNQVRHoSxDSlb2A2Fg&s=9YNZIgsUe4ziY90JLjOXj8EYERPVaxz-_oghDGBt6xg&e=> >> >> The vote will be performed as follows: >> - This letter will be published on dev@ and remain open for at least >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >> votes or a majority of (+1) PMC votes are acquired. Anyone in the community >> can vote. >> >> Please vote accordingly: >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> Alexander Saydakov >> al...@apache.org >> >> >>
