Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-17 Thread Alexander Saydakov
Hi all, This vote is now closed. There were 3 binding +1 votes and no other votes. Thank you to those who voted. On Mon, Dec 16, 2024 at 4:38 PM Alexander Saydakov wrote: > +1 > > - checked GPG signature and SHA512 > - LICENSE and NOTICE look good > - 'make', 'make install', 'make test' successf

Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-16 Thread Alexander Saydakov
+1 - checked GPG signature and SHA512 - LICENSE and NOTICE look good - 'make', 'make install', 'make test' successful On Mon, Dec 16, 2024 at 3:45 PM Jon Malkin wrote: > +1 (binding) > > I checked: > - checksum + signature > - make/make install/make test worked > - LICENSE and NOTICE look good

Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-16 Thread Jon Malkin
+1 (binding) I checked: - checksum + signature - make/make install/make test worked - LICENSE and NOTICE look good I don't have any particular problem with the current directory structure. I think the general expectation is that few people will interact with the raw git repo as opposed to using t

Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-13 Thread Lee Rhodes
This was a brand new directory. I did choose to install emsdk here instead of somewhere else. I wasn't sure where else to put it. Not sure about the others. On Fri, Dec 13, 2024 at 4:08 PM Alexander Saydakov wrote: > I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own > e

Re: [E] Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-13 Thread Alexander Saydakov
I am not aware of 'emsdk' and 'includes'. Perhaps those are in your own environment? We can remove the .zip after extraction. That would be a slight change to Makefile. workflow_settings.yaml is not in version control. I think it is a temporary file, side effect of running some cloud utils. On Fri

Re: [VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-13 Thread Lee Rhodes
+1(binding) Whew! I made it through all the way to "make test" and everything passed! I have a couple of minor comments, which should not impact the release: - In the README.md file there needs to be a blank line prior to "``` ```" blocks. Although these blocks rendered ok in Chrome

[VOTE] Release Apache DataSketches-bigquery-1.0.0-rc1

2024-12-11 Thread Alexander Saydakov
Hello Apache DataSketches PMC and Community, This is a call for vote to release Apache DataSketches-bigquery candidate version 1.0.0-rc1 Apache DataSketches library functions for Google BigQuery. This is the first release of the product. Source repository: - https://github.com/apache/data