RE: [PATCH core 02/16] Core: Removed all Cucumber and deprecated tests from server/Rakefile

Hi Michal, Looking at just this patch it seems it used to run selected driver unit tests and now not anymore. I'm close to contributing a set of (new) fgcp driver tests. Do I need to make any changes anywhere to ensure they get called when anyone runs rake test? Also, in relation to patch 08/16,

RE: [PATCH core 11/16] Core: Check if instance used to create new image exists correctly

Hi Michal, This looks like a case where you are introducing code that, at least in FGCP's case, will result in 5+ calls to retrieve instance details, password, public ip addresses and running status just to check a resource is there, which we discussed in the following issue: https://issues.apach

Re: IMPORTANT: Deprecating driver specific tests in server/tests directory

On Thu, 2012-07-19 at 16:09 -0700, David Lutterkort wrote: > On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > > Sorry for this 'scary' $SUBJECT but this patchset deprecate all tests we > > had in > > server/tests directory in favor of new internal API tests that will be > > stored i

Re: IMPORTANT: Deprecating driver specific tests in server/tests directory

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > Sorry for this 'scary' $SUBJECT but this patchset deprecate all tests we had > in > server/tests directory in favor of new internal API tests that will be stored > in > this directory. Nice stuff; unfortunately, running the tests wit

Re: [PATCH core 7/7] Tests: Added Deltacloud internal API tests into server/tests/deltacloud

On Wed, 2012-07-18 at 18:04 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik ACK .. there are the header tests I was missing ;) David

Re: [PATCH core 6/7] Core: Replaced 'require' by 'load' in deltacloud_rack.rb to make frontend loaded properly outside config.ru

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud_rack.rb |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) What is the problem that this solves ? ACK after adding some explanation to th

Re: [PATCH core 5/7] Core: Added 'provider_name' method to retrieve current API provider value

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud/helpers/driver_helper.rb |4 > 1 file changed, 4 insertions(+) ACK; this should be squashed into 3/7 David

Re: [PATCH core 4/7] Core: The 'supported_collections' helper now return correct array

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud/helpers/deltacloud_helper.rb |3 +++ > 1 file changed, 3 insertions(+) ACK

Re: [PATCH core 3/7] Core: Added X-Deltacloud-Provider and X-Deltacloud-Driver header to HTTP response

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud/helpers.rb |4 > 1 file changed, 4 insertions(+) ACK; the first line of the commit message is too long though, and the commit message ne

Re: [PATCH core 2/7] Core: Removed all Cucumber and deprecated tests from server/Rakefile

On Wed, 2012-07-18 at 18:03 +0200, mfoj...@redhat.com wrote: > From: Michal Fojtik > > The server/Rakefile now hold just one Rake task for executing tests > named 'test'. So executing 'rake test' should make all server API > tests run. ACK to removing the cucumber related tasks, but why remove r

Re: IMPORTANT: Deprecating driver specific tests in server/tests directory

On Wed, 2012-07-18 at 18:12 +0200, Michal Fojtik wrote: > Hi, > > Sorry the [1/1] has 19MB ;-) > > http://omicron.mifo.sk/0001-Core-Moved-all-API-tests-in-server-tests-into-server.patch.gz ACK to this monster ;) David

Re: Poor performance with open nebula driver

Hi Marios, Sorry for the late response. This is the updated state machine for OpenNebula (if I didn't make any mistake) --8<- define_instance_states do start.to(:pending) .on( :create ) pending.to(:running).automatically

[PATCH core 15/16] Core: Added possibility to create blob using string in blob_data

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/drivers/mock/mock_driver.rb | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/server/lib/deltacloud/drivers/mock/mock_driver.rb b/server/lib/deltacloud/drivers/mock/mock_driver.rb

[PATCH core 16/16] Core: Fixed 'render_cdata' helper to die properly when string is nil

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/helpers/deltacloud_helper.rb |2 +- server/tests/deltacloud/deltacloud_helper_test.rb |1 + server/views/blobs/show.xml.haml |3 +-- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH core 14/16] Core: Fixed 'singularize' helper in String to singularize 'properties'

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/core_ext/string.rb |1 + 1 file changed, 1 insertion(+) diff --git a/server/lib/deltacloud/core_ext/string.rb b/server/lib/deltacloud/core_ext/string.rb index abf4a28..bc382ed 100644 --- a/server/lib/deltacloud/co

[PATCH core 13/16] Core: Fixed 'gsub_keys' helper in Hash to work with Ruby 1.9

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/core_ext/hash.rb | 12 +++- server/tests/helpers/core_ext/hash_test.rb | 29 +++- 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/server/lib/deltacloud/core_ext/h

[PATCH core 12/16] Core: Added missing require to instance_states collection

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/collections/instance_states.rb |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/lib/deltacloud/collections/instance_states.rb b/server/lib/deltacloud/collections/instance_states.rb inde

[PATCH core 11/16] Core: Check if instance used to create new image exists correctly

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/collections/images.rb |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/lib/deltacloud/collections/images.rb b/server/lib/deltacloud/collections/images.rb index 2bb836e..6c4583d 100644 -

[PATCH core 10/16] Core: Replaced obsoleted convert_to_xml with xml_to_json helper in buckets

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/collections/buckets.rb | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/server/lib/deltacloud/collections/buckets.rb b/server/lib/deltacloud/collections/buckets.rb index 77a431c..b7

[PATCH core 09/16] Core: Added more collection tests and test_helper to run simplecov

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/Rakefile| 10 +-- .../collections/buckets_collection_test.rb | 64 .../collections/drivers_collection_test.rb | 36 +++ .../collections/images_coll

[PATCH core 07/16] Tests: Added Deltacloud internal API tests into server/tests/deltacloud

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/Rakefile |7 +- server/tests/deltacloud/base_collection_test.rb | 29 + server/tests/deltacloud/collections_test.rb | 34 ++ server/tests/deltacloud/common.rb |

[PATCH core 08/16] Core: Removed obsoleted development dependencies from Gemfile

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/Gemfile | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/server/Gemfile b/server/Gemfile index ed48e01..ef08023 100644 --- a/server/Gemfile +++ b/server/Gemfile @@ -3,14 +3,8 @@ source "http://rubygems.

[PATCH core 02/16] Core: Removed all Cucumber and deprecated tests from server/Rakefile

From: Michal Fojtik The server/Rakefile now hold just one Rake task for executing tests named 'test'. So executing 'rake test' should make all server API tests run. Signed-off-by: Michal fojtik --- server/Rakefile | 124 +-- 1 file changed,

[PATCH core 03/16] Core: Added X-Deltacloud-Provider and X-Deltacloud-Driver header to HTTP response

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/helpers.rb |4 1 file changed, 4 insertions(+) diff --git a/server/lib/deltacloud/helpers.rb b/server/lib/deltacloud/helpers.rb index 0c66103..6566c59 100644 --- a/server/lib/deltacloud/helpers.rb +++ b/server

[PATCH core 05/16] Core: Added 'provider_name' method to retrieve current API provider value

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/helpers/driver_helper.rb |4 1 file changed, 4 insertions(+) diff --git a/server/lib/deltacloud/helpers/driver_helper.rb b/server/lib/deltacloud/helpers/driver_helper.rb index 8ae61c0..5c5e7c6 100644 --- a/se

[PATCH core 04/16] Core: The 'supported_collections' helper now return correct array

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/helpers/deltacloud_helper.rb |3 +++ 1 file changed, 3 insertions(+) diff --git a/server/lib/deltacloud/helpers/deltacloud_helper.rb b/server/lib/deltacloud/helpers/deltacloud_helper.rb index cec22ac..047e1b2 1006

[PATCH core 06/16] Core: Replaced 'require' by 'load' in deltacloud_rack.rb to make frontend loaded properly outside config.ru

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud_rack.rb |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/lib/deltacloud_rack.rb b/server/lib/deltacloud_rack.rb index 1c1301d..3b609ed 100644 --- a/server/lib/deltacloud_rack.rb +++ b/server

[jira] [Commented] (DTACLOUD-259) Unable to describe the loadbalancer using ec2 driver

[ https://issues.apache.org/jira/browse/DTACLOUD-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418189#comment-13418189 ] Deepika Agrawal commented on DTACLOUD-259: -- The response of register and unregi