[jira] [Created] (DELTASPIKE-494) Add support to templates in FacesMessages

2014-01-03 Thread Esteve (JIRA)
Esteve created DELTASPIKE-494: - Summary: Add support to templates in FacesMessages Key: DELTASPIKE-494 URL: https://issues.apache.org/jira/browse/DELTASPIKE-494 Project: DeltaSpike Issue Type: Ne

Re: Servlet Module - Do we really need @Web?

2014-01-03 Thread Thomas Andraschko
Because our customers have different servers (tomcat7 and even 6, glassfish, jboss), so it would be a great enhancement for product development. 2014/1/3 John D. Ament > If you're in servlet 3.1/CDI 1.1 you don't even need the servlet > module (so why include it as a dependency?) > > On Fri, Ja

Re: Servlet Module - Do we really need @Web?

2014-01-03 Thread John D. Ament
If you're in servlet 3.1/CDI 1.1 you don't even need the servlet module (so why include it as a dependency?) On Fri, Jan 3, 2014 at 1:09 PM, Romain Manni-Bucau wrote: > -0 both injections can be different depending on containers using some > advanced stuff out of ee but affecting ee lifecycle (at

Re: Servlet Module - Do we really need @Web?

2014-01-03 Thread Romain Manni-Bucau
-0 both injections can be different depending on containers using some advanced stuff out of ee but affecting ee lifecycle (at least in tomcat) but your proposal sounds acceptable. Le 3 janv. 2014 17:58, "Thomas Andraschko" a écrit : > Hi, > > IMHO @Web is somehow annoying. > HttpServlet e.g. is

Servlet Module - Do we really need @Web?

2014-01-03 Thread Thomas Andraschko
Hi, IMHO @Web is somehow annoying. HttpServlet e.g. is always "web", so @Web is just a overhead and doesn't look nice. Can't we just veto the producers if CDI1.1 is available? The code would be the same with CDI 1.0 + DS, CDI 1.1 without or with DS. Regards, Thomas

Re: DS ExceptionHandling for JSF?

2014-01-03 Thread Thomas Andraschko
Ahh, you already attached an patch. Could you re-upload it? I will take care of it. 2014/1/3 Thomas Andraschko > Ahh cool! > Will you finish it for the next release? > > > 2014/1/3 Cody Lerum > >> See https://issues.apache.org/jira/browse/DELTASPIKE-341 >> >> On Fri, Jan 3, 2014 at 1:21 AM, Th

Re: DS ExceptionHandling for JSF?

2014-01-03 Thread Thomas Andraschko
Ahh cool! Will you finish it for the next release? 2014/1/3 Cody Lerum > See https://issues.apache.org/jira/browse/DELTASPIKE-341 > > On Fri, Jan 3, 2014 at 1:21 AM, Thomas Andraschko > wrote: > > Hi, > > > > what about providing DS' exception handling (@ExceptionHandler etc.) for > > JSF? > >

Re: DS ExceptionHandling for JSF?

2014-01-03 Thread Cody Lerum
See https://issues.apache.org/jira/browse/DELTASPIKE-341 On Fri, Jan 3, 2014 at 1:21 AM, Thomas Andraschko wrote: > Hi, > > what about providing DS' exception handling (@ExceptionHandler etc.) for > JSF? > AFAICS we would just need a small JSF ExceptionHandler. > > Regards, > Thomas

Re: Optimizing the integration tests

2014-01-03 Thread Ron Smeral
Hi Christian, looking at the arquillian.xml files, they are 99% the same, the only one that actually differs (other than whitespace, comments and missing cdicontainer.version property) is the one in the data module, containing a testDatabase configuration for tomee. So, we could have just one

[jira] [Updated] (DELTASPIKE-493) inconsistent handling in WindowContextImpl#closeWindow

2014-01-03 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-493: Summary: inconsistent handling in WindowContextImpl#closeWindow (was: inconsis

[jira] [Resolved] (DELTASPIKE-493) inconsistent handling in WindowContextImpl#closeWindow

2014-01-03 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved DELTASPIKE-493. - Resolution: Fixed > inconsistent handling in WindowContextImpl#closeWindow >

[jira] [Created] (DELTASPIKE-493) inconsistent handling in WindowContext#closeWindow

2014-01-03 Thread Gerhard Petracek (JIRA)
Gerhard Petracek created DELTASPIKE-493: --- Summary: inconsistent handling in WindowContext#closeWindow Key: DELTASPIKE-493 URL: https://issues.apache.org/jira/browse/DELTASPIKE-493 Project: DeltaS

Re: Test-Control injects in test class object only

2014-01-03 Thread Gerhard Petracek
short addition: i've added a test for it and it looks fine here (see [1]). fyi - basically there are two "modes": #1 the test-class is a cdi-bean as well (src/test/resources/META-INF/beans.xml is needed) #2 the test-class isn't a cdi-bean (due to a missing beans.xml or @Typed() or @Exclude,...) -

Re: Test-Control injects in test class object only

2014-01-03 Thread Gerhard Petracek
hi dirk, deltaspike just delegates the injection to the cdi-container. regards, gerhard 2014/1/3 Dirk Weil > Hi! > > > > I've just come around Test-Control - great module, simplifies in-container > testing a lot. But I discovered one thing and I'm not sure if it's intended > or a bug: > > >

Test-Control injects in test class object only

2014-01-03 Thread Dirk Weil
Hi! I've just come around Test-Control - great module, simplifies in-container testing a lot. But I discovered one thing and I'm not sure if it's intended or a bug: @Inject is resolved for fields of the test class object itself only, not for fields of base classes. As a workaround I use Bea

Re: Optimizing the integration tests

2014-01-03 Thread Gerhard Petracek
@christian: +1 (@as7: sounds like a missing cleanup, like it's done for tomee) regards, gerhard 2014/1/3 Christian Kaltepoth > Hey Ron, > > yeah, there are differences between arquillian.xml files. But why? I don't > see any reason for having different arquillian.xml files between modules. >

DS ExceptionHandling for JSF?

2014-01-03 Thread Thomas Andraschko
Hi, what about providing DS' exception handling (@ExceptionHandler etc.) for JSF? AFAICS we would just need a small JSF ExceptionHandler. Regards, Thomas