Re: CI for DeltaSpike?

@john iIRC ASM should be shaded, not sure why it happends Am Freitag, 1. Dezember 2017 schrieb Matej Novotny : > Doesn't look like the error I saw, for me deployment was OK but the test > failed (there was no redirection done on button click in the selenium test > so it then crashed with

Re: CI for DeltaSpike?

Doesn't look like the error I saw, for me deployment was OK but the test failed (there was no redirection done on button click in the selenium test so it then crashed with NoSuchElementException). Haven't really dug deeper as I am rather unfamiliar with that module, just found out what commits

Re: CI for DeltaSpike?

I'm not sure if its the cause or not, but I see this when running the failing tests on wildfly 10.1 10:31:46,124 WARN [org.jboss.modules] (Weld Thread Pool -- 6) Failed to define class org.apache.deltaspike.proxy.impl.AsmDeltaSpikeProxyClassGenerator$1 in Module

Re: CI for DeltaSpike?

The main issues are that we're all independent contributors to DS, all with the same level of rights to write to the repo. We typically don't do PRs. We actually do have a PR job in Jenkins for those external parties that do raise PRs ->

[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

[ https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274489#comment-16274489 ] ASF subversion and git services commented on DELTASPIKE-940: Commit

[jira] [Commented] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

[ https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274449#comment-16274449 ] John D. Ament commented on DELTASPIKE-940: -- got it. The issue looks pretty straight forward,

Re: CI for DeltaSpike?

@matej You also reopened a issue that i created. I'm currently in brasil, so i dont have time to look at it. I removed this call as its actually not required and the wrapping in PrimeFaces works fine. Not sure why it breaks navigation but we can simple revert it for this release. Am Freitag, 1.

Re: CI for DeltaSpike?

hi matej, imo the main point here is that in the past we received too many wrong failures and almost no commit really broke the backward compatibility. regards, gerhard 2017-12-01 11:49 GMT+01:00 Matej Novotny : > Hi Gerhard, > > > i'm not sure if others are still

[jira] [Reopened] (DELTASPIKE-940) @Transactional and @EntityManagerConfig each use a different method to resolve EntityManagers

[ https://issues.apache.org/jira/browse/DELTASPIKE-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Novotny reopened DELTASPIKE-940: -- Commits for this issue break 120 tests in the module (over 2/3 of all tests in the

Re: CI for DeltaSpike?

Hi Gerhard, > i'm not sure if others are still following it. at the time i did the > releases, it was a mandatory step. Yes, I hope nobody releases without actually testing it at all. But this check IMO comes too late - there are multiple "fixes" present, where the author apparently didn't even

[jira] [Reopened] (DELTASPIKE-1282) DeltaSpikeFacesContextWrapper leaks on TomEE

[ https://issues.apache.org/jira/browse/DELTASPIKE-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Novotny reopened DELTASPIKE-1282: --- The [first commit