Re: [jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-07 Thread Romain Manni-Bucau
@JL it should be running with snapshot too Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-02-07 Jean-Louis MONTEIRO : > Sure, I cannot commit, so for now, my patch is run

Re: [jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-07 Thread Jean-Louis MONTEIRO
Sure, I cannot commit, so for now, my patch is running fine locally ;-) On Monday I can just refresh my local repo and recompile everything. Thanks anyway. JLouis 2014-02-07 Thomas Hug : > If it can wait 'til the weekend I can pick it up :-) > > > On Fri, Feb 7, 2014 at 9:21 AM, Jean-Louis MONT

Re: [jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-07 Thread Thomas Hug
If it can wait 'til the weekend I can pick it up :-) On Fri, Feb 7, 2014 at 9:21 AM, Jean-Louis MONTEIRO wrote: > Thanks Thomas. > Will you do that yourself, or do you want me to do the arquillian test and > submit a new patch? > > JLouis > > > 2014-02-07 Thomas Hug (JIRA) : > > > > > [ > >

Re: [jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-07 Thread Jean-Louis MONTEIRO
Thanks Thomas. Will you do that yourself, or do you want me to do the arquillian test and submit a new patch? JLouis 2014-02-07 Thomas Hug (JIRA) : > > [ > https://issues.apache.org/jira/browse/DELTASPIKE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedComme

[jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-07 Thread Thomas Hug (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894286#comment-13894286 ] Thomas Hug commented on DELTASPIKE-518: --- Looks good. I'd prefer an Arquillian te

[jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-06 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893458#comment-13893458 ] Romain Manni-Bucau commented on DELTASPIKE-518: --- Excepted the fact I'd s

Re: [jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-06 Thread Jean-Louis MONTEIRO
Hello guys, Just submitted a patch for that issue. There is also a test case now. Would be great if someone car have a look and lemme know. In my opinion, the unwrap method should be used in any case and we could simplify all the factory stuff and remove the 3 implementations I guess. Happy to

[jira] [Commented] (DELTASPIKE-518) DS Data should support Wrapped JPA APIs

2014-02-06 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/DELTASPIKE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893437#comment-13893437 ] Romain Manni-Bucau commented on DELTASPIKE-518: --- +1 sirona is doing it a